Closed Bug 1405079 Opened 7 years ago Closed 7 years ago

Add back `defaultNewTabExperience` and `defaultMailClient`

Categories

(Firefox for iOS :: Telemetry, enhancement)

Other
iOS
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
fxios 10.0 ---

People

(Reporter: garvan, Assigned: garvan)

References

Details

Attachments

(1 file, 1 obsolete file)

55 bytes, text/x-github-pull-request
justindarc
: review+
Details | Review
Follow up from 140297, which was moving to telemetry-ios lib. The following code was removed on first landing, need to add back these measurements: - if let newTabChoice = self.prefs.stringForKey(NewTabAccessors.PrefKey) { - out["defaultNewTabExperience"] = newTabChoice as AnyObject? - } - if let chosenEmailClient = self.prefs.stringForKey(PrefsKeys.KeyMailToOption) { - out["defaultMailClient"] = chosenEmailClient as AnyObject? - }
Assignee: nobody → gkeeley
Depends on: 140297
Depends on: 1402976
No longer depends on: 140297
Correction I meant bug 1402976 in the first comment
Attached file Pull request (obsolete) —
Part one, add to lib. Next up, add to Firefox iOS code
Attachment #8914477 - Flags: review?(jdarcangelo)
Attached file Pull request
Attachment #8914477 - Attachment is obsolete: true
Attachment #8914477 - Flags: review?(jdarcangelo)
Attachment #8915712 - Flags: review?(jdarcangelo)
Attachment #8915712 - Flags: review?(jdarcangelo) → review+
landed master and 10.x
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: