Closed
Bug 1405121
Opened 7 years ago
Closed 7 years ago
Add a fast path for native objects to TestIntegrityLevel
Categories
(Core :: JavaScript: Standard Library, enhancement)
Core
JavaScript: Standard Library
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(1 file)
|
11.59 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
This makes Object.isFrozen/isSealed much faster, because we no longer need to collect all property ids.
|
Assignee | |
Comment 1•7 years ago
|
||
TestIntegrityLevel can be improved for native objects when we directly iterate over all shapes instead of calling |GetPropertyKeys| + |GetOwnPropertyDescriptor|. AFAICS we only need to first resolve lazy properties, have a special case for typed/dense elements, and then we can directly iterate over all shapes. Test262 doesn't have any tests for calling TestIntegrityLevel on typed arrays, so I've also added two test cases to cover TestIntegrityLevel on non-detached and on detached typed arrays.
Attachment #8914676 -
Flags: review?(jdemooij)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8914676 [details] [diff] [review] bug1405121.patch Review of attachment 8914676 [details] [diff] [review]: ----------------------------------------------------------------- Sweet.
Attachment #8914676 -
Flags: review?(jdemooij) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b7a5a3ae76417013a8150dddbc20628d694254bd
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c5c5b9eff4c0 Add fast path for native objects to TestIntegrityLevel. r=jandem
Keywords: checkin-needed
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c5c5b9eff4c0
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•