1405161 - Move getIsEnabled configuration functions (e.g. highlights) to ActivityStreamConfiguration

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Activity Stream, enhancement, P5)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Right now we're duplicating code to query whether or not Pocket is enabled [1] and this can lead to errors (e.g. [2] should use resources to get the default value).

In bug 1404460, I added an ActivityStreamConfiguration file: we should add `isPocketEnabled` functions and similar to that file, which will call this sharedPrefs code.

[2]: http://searchfox.org/mozilla-central/rev/a4702203522745baff21e519035b6c946b7d710d/mobile/android/base/java/org/mozilla/gecko/activitystream/homepanel/ActivityStreamPanel.java#114

Comment 1

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 2

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.