Closed Bug 1405169 Opened 2 years ago Closed 2 years ago

Fix refcount macro inheritance chains in HTML element classes

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: qdot, Assigned: qdot)

References

Details

Attachments

(1 file)

There are quite a few HTML*Element classes that have ADDREF/RELEASE as Element instead of whatever their direct superclass is. Fix these up, possibly simplifying CC macros along the way.

Would normally take care of these while bug 1387169, but many offending classes don't have XPCOM interfaces and may be missed, so just sweeping it all up here instead.
Comment on attachment 8914562 [details]
Bug 1405169 - Fix/Simplify Refcount and CC macros for HTML Element classes;

https://reviewboard.mozilla.org/r/185890/#review191508

r=me
Attachment #8914562 - Flags: review?(bzbarsky) → review+
Pushed by kmachulis@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7d914237e51c
Fix/Simplify Refcount and CC macros for HTML Element classes; r=bz
https://hg.mozilla.org/mozilla-central/rev/7d914237e51c
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
I think this used to be a performance improvement, to avoid the calls to the intermediary base class' AddRef/Release. Not saying we should keep it, but given that the only benefit of this is that we'd do refcount logging on the intermediary base class, I don't think it's worth much cost.
You need to log in before you can comment on or make changes to this bug.