1405252 - Migrate browser_webconsole_console_logging_workers_api.js to the new frontend

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

This could be split in 2 tests:
- a mochitest to make sure we do catch worker logs
- a mocha test to test that filtering works on a worker message

Let's see if there any difference between a worker message packet and a regular one. If not, we might even want to skip the mocha test.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1405252 - Enable browser_webconsole_console_logging_workers_api.js in the new frontend; .

Review commit: https://reviewboard.mozilla.org/r/201542/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/201542/

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8930386 [details]
Bug 1405252 - Enable browser_webconsole_console_logging_workers_api.js in the new frontend; .

https://reviewboard.mozilla.org/r/201542/#review207394

Looks good, thanks for progress with the test-conversion Nicolas!
Honza

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa2c49a11df2
Enable browser_webconsole_console_logging_workers_api.js in the new frontend; r=Honza.

Comment 4

[Andreea Pavel [:apavel]]

Backed out for failing devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_filters.js on a CLOSED TREE

Push that caused the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=aa2c49a11df2fceba71e44082e2663467d11deb2&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=146792112&repo=autoland&lineNumber=3385

Backout: https://hg.mozilla.org/integration/autoland/rev/11865acd385763e5c7c4c87d6f4e7785a0f28269

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

My bad, I thought I had pushed it to try

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8930386 [details]
Bug 1405252 - Enable browser_webconsole_console_logging_workers_api.js in the new frontend; .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/201542/diff/1-2/

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8930386 [details]
Bug 1405252 - Enable browser_webconsole_console_logging_workers_api.js in the new frontend; .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/201542/diff/2-3/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cac561542218
Enable browser_webconsole_console_logging_workers_api.js in the new frontend; r=Honza.

Comment 9

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/cac561542218

Comment 10

[Gerry Chang [:gchang]]

Mark 58 won't fix.