Closed Bug 1405252 Opened 2 years ago Closed 2 years ago

Migrate browser_webconsole_console_logging_workers_api.js to the new frontend

Categories

(DevTools :: Console, enhancement, P1)

enhancement

Tracking

(firefox57 wontfix, firefox58 wontfix, firefox59 fixed)

RESOLVED FIXED
Firefox 59
Tracking Status
firefox57 --- wontfix
firefox58 --- wontfix
firefox59 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

(Whiteboard: [newconsole-mvp])

Attachments

(1 file)

This could be split in 2 tests:
- a mochitest to make sure we do catch worker logs
- a mocha test to test that filtering works on a worker message

Let's see if there any difference between a worker message packet and a regular one. If not, we might even want to skip the mocha test.
Priority: -- → P3
Priority: P3 → P2
Whiteboard: [newconsole-mvp]
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment on attachment 8930386 [details]
Bug 1405252 - Enable browser_webconsole_console_logging_workers_api.js in the new frontend; .

https://reviewboard.mozilla.org/r/201542/#review207394

Looks good, thanks for progress with the test-conversion Nicolas!
Honza
Attachment #8930386 - Flags: review?(odvarko) → review+
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aa2c49a11df2
Enable browser_webconsole_console_logging_workers_api.js in the new frontend; r=Honza.
My bad, I thought I had pushed it to try
Flags: needinfo?(nchevobbe)
Attachment #8930386 - Flags: review+ → review?(odvarko)
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cac561542218
Enable browser_webconsole_console_logging_workers_api.js in the new frontend; r=Honza.
https://hg.mozilla.org/mozilla-central/rev/cac561542218
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Mark 58 won't fix.
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.