1405258 - Update libcubeb to revision ba2a89611875cd9f2dabae99a362461b03c0dd3d

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, defect, P2)

Description

[Paul Adenot (:padenot)]

This include the following commits from upstream, and fixes some gecko bugs:

ba2a8 Implement some rudimentary underrun protection for duplex streams (#354) (bug 1393689)
d6ae2 pulse: Cleanup potentionally dangling pointers.
69b9b pulse: Wake up waiting operation once on EOL. 
7e39a audiounit: expect error when set device info. (#358) (followup bug 1367702)
c5493 pulse: Improve handling when there are no pulse source/sink. (#360)  (bug 1399978)

Comment 1

[Paul Adenot (:padenot)]

This has all been reviewed upstream, by :achronop (ba2a8, d6ae2, 69b9b) and myself (c5493, 7e39a).

Comment 2

[Paul Adenot (:padenot)]

Attachment: Update libcubeb to revision ba2a89611875cd9f2dabae99a362461b03c0dd3d

MozReview-Commit-ID: PngLiVneAh

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3bdc753d11f0
Update libcubeb to revision ba2a89611875cd9f2dabae99a362461b03c0dd3d

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/40f7a69cec34
Update libcubeb to 40cd4ad0 to fix warnings as errors bustage.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3bdc753d11f0
https://hg.mozilla.org/mozilla-central/rev/40f7a69cec34

Comment 6

[xpeng]

will the modification be merged into firefox 56/57?  
the crash issue is serious: audiounit: expect error when set device info. (#358) (followup bug 1367702)

Comment 7

[Paul Adenot (:padenot)]

Alex, can you nominate the OSX bits here ?

Comment 8

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1405258 - Uplift part of cubeb import ba2a896. r?padenot

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1384053
[User impact if declined]: Crash
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes for a long time
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: No
[Why is the change risky/not risky?]:small patch which is proven to fix the issue according to the crash-stats
[String changes made/needed]:

Comment 9

[Paul Adenot (:padenot)]

Comment on attachment 8918288 [details] [diff] [review]
Bug 1405258 - Uplift part of cubeb import ba2a896. r?padenot

Review of attachment 8918288 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8918288 [details] [diff] [review]
Bug 1405258 - Uplift part of cubeb import ba2a896. r?padenot

Crash fix that was verified on Nightly, Beta57+

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2b831e7a64bf