1405282 - Setting for More Window Drag Space on Maximized windows

Status: NEW

(Firefox :: Toolbars and Customization, defect, P5)

Description

[Emanuele]

In reference to bug #1349552 ,the option to add extra space actually isn't applied on maximized windows. 

I think the experience is not optimal since the user probably expects that enabling that option every window will gain that extra space (useful for fast gestures to resize and organize windows on many desktops shells).

Comment 1

[:Gijs (he/him)]

Dupe of bug 1404497?

Comment 2

[Emanuele]

(In reply to :Gijs from comment #1)
> Dupe of bug 1404497?

Partially. That bug refers to the drag space on the left and on the right of tabs. Here I'd like to point the space added at the top of tabs.

However, all the considerations about the UX are the same

Comment 3

[Edo Karabas]

IF not a dupe of bug 1404497 then I would say wontfix/invalid. I don't see much reason to add a space above tabs in maximized mode. If someone wish to have it, there is still an option to enable Titlebar and this will serve a purpose of it completely.

Comment 4

[Johann Hofmann [:johannh]]

(In reply to Eddward from comment #3)
> IF not a dupe of bug 1404497 then I would say wontfix/invalid. I don't see
> much reason to add a space above tabs in maximized mode. If someone wish to
> have it, there is still an option to enable Titlebar and this will serve a
> purpose of it completely.

The user experience is still not optimal, the checkbox in customize mode can be checked without an effect. We'll figure something out.

Comment 5

[Emanuele]

(In reply to Eddward from comment #3)
> IF not a dupe of bug 1404497 then I would say wontfix/invalid. I don't see
> much reason to add a space above tabs in maximized mode. If someone wish to
> have it, there is still an option to enable Titlebar and this will serve a
> purpose of it completely.

I don't think that enabling the titlebar could be a good replacement for it.

Above all: is there any good reason to disable a feature that is already implemented for non-maximized windows, and that break the user experience? (that space is used desktop-wise to perform some gestures on lot of desktop environments).

Comment 6

[Johann Hofmann [:johannh]]

Attachment: Bug 1405282 - Show extra drag space even in fullscreen and maximized mode.

Review commit: https://reviewboard.mozilla.org/r/196648/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/196648/

Comment 7

[Johann Hofmann [:johannh]]

Comment on attachment 8925503 [details]
Bug 1405282 - Show extra drag space even in fullscreen and maximized mode.

Stephen, I believe, also looking at the issues in bug 1406136, that there might be advantages in always showing the extra drag space, even in fullscreen or maximized mode. We would completely avoid the UX problem from this bug and respect the user choice consistently, without making assumptions about why or why not the user might want that space in maximized mode. 

As another option we could also just do that on OSX, which would resolve bug 1406136 but not help with this bug.

If you don't think this is a good idea, I'd just say we disable the checkbox in maximized mode the way we do it when the menubar or the titlebar are shown.

What do you think?

Comment 8

[Firefox Bug Husbandry Bot]

https://wiki.mozilla.org/Bugmasters/Projects/Bug_Handling/Bug_Husbandry#Move_fix-optionals

Comment 9

[:Gijs (he/him)]

Is it still realistic that this'll make 58, or should we mark 58 as wontfix and try to get this in for 59 only at this point?

Comment 10

[Johann Hofmann [:johannh]]

I don't know. If Stephen is going to take a look we could land this quite quickly, though I don't think it's urgent to get into 58 either.

Comment 11

[Johann Hofmann [:johannh]]

Unassigning myself while we wait for an answer...

Comment 12

[:Gijs (he/him)]

Downprio'ing to get this off radars given that there's no clarity about whether we want to ship this.

Comment 16

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is relatively low, S3. However, the bug has 3 duplicates.
:Gijs, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Comment 17

[BugBot (nomail) [:suhaib / :marco/ :calixte]]

The last needinfo from me was triggered in error by recent activity on the bug. I'm clearing the needinfo since this is a very old bug and I don't know if it's still relevant.

Comment 18

[BugBot [:suhaib / :marco/ :calixte]]

Clear a needinfo that is pending on an inactive user.

Inactive users most likely will not respond; if the missing information is essential and cannot be collected another way, the bug maybe should be closed as INCOMPLETE.

For more information, please visit auto_nag documentation.