Closed Bug 1405288 Opened 3 years ago Closed 2 years ago

Remove the backward-compatibility code for old inspector features

Categories

(DevTools :: Inspector, enhancement, P3)

enhancement

Tracking

(firefox59 fixed)

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- fixed

People

(Reporter: pbro, Assigned: pbro)

References

(Blocks 1 open bug)

Details

Attachments

(4 files)

The duplicate node feature was added to the inspector in Firefox 44 (in bug 1208864).

On the client-side, there is code for checking that the feature exists:
http://searchfox.org/mozilla-central/rev/a4702203522745baff21e519035b6c946b7d710d/devtools/client/inspector/inspector.js#229

It's probably safe to remove this code now.

In bug 1405007, we're talking about supporting backward compatibility all the way up to ESR.
Severity: normal → enhancement
Priority: -- → P3
Let's use this for all inspector-related pre ESR backward compat code.
Summary: Remove the backward-compatibility code for the inspector's duplicateNode feature → Remove the backward-compatibility code for old inspector features
Just dropped 4 patches here. Not to be reviewed yet. I'm sure some things will break. So I'm still testing locally.
Well, surprisingly, this seems to be working fine: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a26722278a2c083a4beacbe5e9908ecb339722f1&group_state=expanded
(nevermind the bc failures, they're unrelated and being fixed in bug 1410005)
Attachment #8920067 - Flags: review?(poirot.alex)
Attachment #8920068 - Flags: review?(poirot.alex)
Attachment #8920069 - Flags: review?(poirot.alex)
Attachment #8920070 - Flags: review?(poirot.alex)
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Ideally, we should wait for bug 1405008 to land before landing this.
Depends on: 1405008
Comment on attachment 8920067 [details]
Bug 1405288 - Remove resolveRelativeURL actor method check from the inspector

https://reviewboard.mozilla.org/r/191062/#review206378

Sorry it took me so long to get back to these patches. I was waiting to proceed with bug 1405008, which I pushed this morning.

Otherwise these pathes all look good to me.
Attachment #8920067 - Flags: review?(poirot.alex) → review+
Comment on attachment 8920068 [details]
Bug 1405288 - Remove duplicateNode actor method check from the inspector

https://reviewboard.mozilla.org/r/191064/#review206382
Attachment #8920068 - Flags: review?(poirot.alex) → review+
Comment on attachment 8920069 [details]
Bug 1405288 - Remove scrollIntoView actor method check from the inspector

https://reviewboard.mozilla.org/r/191066/#review206384
Attachment #8920069 - Flags: review?(poirot.alex) → review+
Comment on attachment 8920070 [details]
Bug 1405288 - Remove pickColorFromPage actor method check from then inspector

https://reviewboard.mozilla.org/r/191068/#review206386
Attachment #8920070 - Flags: review?(poirot.alex) → review+
Pushed by pbrosset@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/16c50fd548b6
Remove resolveRelativeURL actor method check from the inspector r=ochameau
https://hg.mozilla.org/integration/autoland/rev/5bc74f98b7ce
Remove duplicateNode actor method check from the inspector r=ochameau
https://hg.mozilla.org/integration/autoland/rev/531086ab7eba
Remove scrollIntoView actor method check from the inspector r=ochameau
https://hg.mozilla.org/integration/autoland/rev/a13174ac2d95
Remove pickColorFromPage actor method check from then inspector r=ochameau
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.