1405288 - Remove the backward-compatibility code for old inspector features

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Patrick Brosset <:pbro>]

The duplicate node feature was added to the inspector in Firefox 44 (in bug 1208864).

On the client-side, there is code for checking that the feature exists:
http://searchfox.org/mozilla-central/rev/a4702203522745baff21e519035b6c946b7d710d/devtools/client/inspector/inspector.js#229

It's probably safe to remove this code now.

In bug 1405007, we're talking about supporting backward compatibility all the way up to ESR.

Comment 1

[Patrick Brosset <:pbro>]

Let's use this for all inspector-related pre ESR backward compat code.

Comment 2

[Patrick Brosset <:pbro>]

Attachment: Bug 1405288 - Remove resolveRelativeURL actor method check from the inspector

The resolveRelativeURL actor method was added in bug 921102 which shipped
with Firefox 40.
This was 3 years ago, and well older than the latest current ESR (52), which
is the latest version we support.

Review commit: https://reviewboard.mozilla.org/r/191062/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/191062/

Comment 3

[Patrick Brosset <:pbro>]

Attachment: Bug 1405288 - Remove duplicateNode actor method check from the inspector

This method was added in bug 1208864 2 years ago and shipped with Firefox 44.
We support all the way to the latest ESR, which now is 52.
So let's remove this backward compat code.

Review commit: https://reviewboard.mozilla.org/r/191064/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/191064/

Comment 4

[Patrick Brosset <:pbro>]

Attachment: Bug 1405288 - Remove scrollIntoView actor method check from the inspector

The scrollIntoView actor method was added in bug 901250 3 years ago and
shipped with FF 40.
We support all the way back to the latest ESR (52 now).
So let's drop this backward compat check code.

Review commit: https://reviewboard.mozilla.org/r/191066/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/191066/

Comment 5

[Patrick Brosset <:pbro>]

Attachment: Bug 1405288 - Remove pickColorFromPage actor method check from then inspector

This method was added in bug 1262439 last year, and shipped with FF50.
We support all the way back to the latest ESR (52 now).
So let's remove the backward compat code for this method.

Review commit: https://reviewboard.mozilla.org/r/191068/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/191068/

Comment 6

[Patrick Brosset <:pbro>]

Just dropped 4 patches here. Not to be reviewed yet. I'm sure some things will break. So I'm still testing locally.

Comment 7

[Patrick Brosset <:pbro>]

Well, surprisingly, this seems to be working fine: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a26722278a2c083a4beacbe5e9908ecb339722f1&group_state=expanded
(nevermind the bc failures, they're unrelated and being fixed in bug 1410005)

Comment 8

[Alexandre Poirot [:ochameau]]

Ideally, we should wait for bug 1405008 to land before landing this.

Comment 9

[Alexandre Poirot [:ochameau]]

Comment on attachment 8920067 [details]
Bug 1405288 - Remove resolveRelativeURL actor method check from the inspector

https://reviewboard.mozilla.org/r/191062/#review206378

Sorry it took me so long to get back to these patches. I was waiting to proceed with bug 1405008, which I pushed this morning.

Otherwise these pathes all look good to me.

Comment 10

[Alexandre Poirot [:ochameau]]

Comment on attachment 8920068 [details]
Bug 1405288 - Remove duplicateNode actor method check from the inspector

https://reviewboard.mozilla.org/r/191064/#review206382

Comment 11

[Alexandre Poirot [:ochameau]]

Comment on attachment 8920069 [details]
Bug 1405288 - Remove scrollIntoView actor method check from the inspector

https://reviewboard.mozilla.org/r/191066/#review206384

Comment 12

[Alexandre Poirot [:ochameau]]

Comment on attachment 8920070 [details]
Bug 1405288 - Remove pickColorFromPage actor method check from then inspector

https://reviewboard.mozilla.org/r/191068/#review206386

Comment 13

[Patrick Brosset <:pbro>]

Comment on attachment 8920067 [details]
Bug 1405288 - Remove resolveRelativeURL actor method check from the inspector

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/191062/diff/1-2/

Comment 14

[Patrick Brosset <:pbro>]

Comment on attachment 8920068 [details]
Bug 1405288 - Remove duplicateNode actor method check from the inspector

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/191064/diff/1-2/

Comment 15

[Patrick Brosset <:pbro>]

Comment on attachment 8920069 [details]
Bug 1405288 - Remove scrollIntoView actor method check from the inspector

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/191066/diff/1-2/

Comment 16

[Patrick Brosset <:pbro>]

Comment on attachment 8920070 [details]
Bug 1405288 - Remove pickColorFromPage actor method check from then inspector

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/191068/diff/1-2/

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16c50fd548b6
Remove resolveRelativeURL actor method check from the inspector r=ochameau
https://hg.mozilla.org/integration/autoland/rev/5bc74f98b7ce
Remove duplicateNode actor method check from the inspector r=ochameau
https://hg.mozilla.org/integration/autoland/rev/531086ab7eba
Remove scrollIntoView actor method check from the inspector r=ochameau
https://hg.mozilla.org/integration/autoland/rev/a13174ac2d95
Remove pickColorFromPage actor method check from then inspector r=ochameau

Comment 18

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/16c50fd548b6
https://hg.mozilla.org/mozilla-central/rev/5bc74f98b7ce
https://hg.mozilla.org/mozilla-central/rev/531086ab7eba
https://hg.mozilla.org/mozilla-central/rev/a13174ac2d95