Closed
Bug 1405296
Opened 7 years ago
Closed 7 years ago
The Tiles context menu button "(...)" slightly overlaps the Section info symbol "(?)" on Windows
Categories
(Firefox :: New Tab Page, defect)
Tracking
()
VERIFIED
FIXED
Firefox 58
People
(Reporter: cmuresan, Assigned: Mardak)
References
Details
Attachments
(1 file)
52.35 KB,
image/png
|
Details |
[Affected versions]: - Firefox 58.0a1 Build ID 20171003100226 [Affected Platforms]: - All Windows [Steps to reproduce]: 1. Start the browser and open a New Tab. 2. Hover the last tile in the Top Sites section. 3. Observe the context menu button. [Expected results]: - The context menu button does not overlap any other button. [Actual results]: - The context menu button slightly overlaps the section info button. [Notes]: - The issue is also reproducible if you hover the 3rd Top Story or the 3rd Highlight tile. - The issue is not reproducible on Mac or Linux. - Attached a screen shot of the issue.
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Comment 1•7 years ago
|
||
Fixed by https://github.com/mozilla/activity-stream/pull/3644 to be uplifted via bug 1405539.
Assignee: nobody → edilee
Blocks: 1405539
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 2•7 years ago
|
||
The issue is no longer reproducible on the latest Nightly 58.0a1 (Build ID 20171009220104) on Windows 10 x64.
Status: RESOLVED → VERIFIED
Comment 3•7 years ago
|
||
This issue is affecting the Firefox 57 build. I strongly recommend uplifting this fix in 57, too, before the merge. This will improve the feature's UX.
status-firefox57:
--- → affected
Comment 4•7 years ago
|
||
[Tracking Requested - why for this release]: See the above comment.
tracking-firefox57:
--- → ?
Updated•7 years ago
|
Flags: needinfo?(edilee)
Target Milestone: --- → Firefox 58
Assignee | ||
Comment 5•7 years ago
|
||
The fix from comment 20 is a bit involved and is part of adding the doorhanger look. If we were to uplift something, it would probably be a smaller css-only fix adjusting the spacing / sizing of things. I suppose who is to make the call if https://bug1405296.bmoattachments.org/attachment.cgi?id=8914719 is acceptable or must fix for 57?
Flags: needinfo?(edilee) → needinfo?(tspurway)
Comment 6•7 years ago
|
||
This bug does not affect the usability of either the context menu or the info doorhanger - both controls are still easily accessible. Because the patch that fixes this is non-trivial and consists of other changes that are unrelated to this bug, I think it's too risky to uplift at this point in the cycle.
Flags: needinfo?(tspurway)
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•