1405303 - Sometimes page actions are hidden on browser restore

Status: RESOLVED INCOMPLETE

(Firefox :: Address Bar, enhancement, P5)

Description

[Jonathan Kingston [:jkt] he/him]

I sometimes see the meatballs, pocket, star etc hidden on session restore.

On inspecting this I see the following CSS causing this:

#urlbar[pageproxystate="invalid"] > #page-action-buttons > .urlbar-page-action

This appears to be have been put in place by Bug 1388835.

I can't cleanly replicate it however it might be to do with having about pages when restoring tabs?

I have "Show your windows and tabs from last time" selected in about:preferences

Comment 1

[:Gijs (he/him)]

What's the state of the page that's open on restore when this happens, and does the content of the url bar match that page's url or does it have other typing in it or something?

Comment 2

[:Gijs (he/him)]

Going to close this as incomplete for now and remove from photon lists, because it's not clear what causes this, if it isn't by design, and it's not really related to photon directly as other things will also be hidden if pageproxystate=invalid  . If we have more details / solid STR that indicate we're setting pageproxystate=invalid when we shouldn't be, then we can reopen, but that would be a bug irrespective of the state of the page action buttons. Keeping ni for Jonathan in case he has more info here and wants to reopen and look at this again.

Comment 3

[Jonathan Kingston [:jkt] he/him]

Removing NI, I have seen this again recently I think it's poor network+compiling code that triggers it however again I can't produce a solid STR for this still.