1405352 - Migrate browser_webconsole_jsterm.js to the new frontend

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1405352 - Split browser_webconsole_jsterm.js in multiple tests; .

The test was doing a lot of things and was hard to follow.
Here we split it so we can have dedicated tests for each helpers.

Review commit: https://reviewboard.mozilla.org/r/216862/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216862/

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8948982 [details]
Bug 1405352 - Split browser_webconsole_jsterm.js in multiple tests; .

https://reviewboard.mozilla.org/r/216862/#review226476

Very nice clean up!
Just couple of notes.

R+ assuming try is green
Honza

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_jsterm_error_docs.js:12
(Diff revision 1)
>  
> -var jsterm;
> +add_task(async function () {
> +  const hud = await openNewTabAndConsole(TEST_URI);
> +  const {jsterm} = hud;
>  
> -add_task(function* () {
> +  // Check that errors with entires in errordocs.js display links next to their messages.

typo: entires -> entries

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_jsterm_error_docs.js
(Diff revision 1)
> -    }, `error links to ${title}`);
> -  }
> -
> +    const learnMoreLink = node.querySelector(".learn-more-link");
> +    ok(learnMoreLink, `There is a [Learn More] link for "${errorMessageName}" error`);
> +    is(learnMoreLink.title, title, `The link has the expected "${title}" title`);
> -  // Ensure that dom errors, with error numbers outside of the range
> -  // of valid js.msg errors, don't cause crashes (bug 1270721).
> -  yield jsterm.execute("new Request('',{redirect:'foo'})");

What was this for? Not necessary anymore?

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8948982 [details]
Bug 1405352 - Split browser_webconsole_jsterm.js in multiple tests; .

https://reviewboard.mozilla.org/r/216862/#review226476

> What was this for? Not necessary anymore?

oops, I think I missed this one

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8948982 [details]
Bug 1405352 - Split browser_webconsole_jsterm.js in multiple tests; .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/216862/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b0cf7518d66
Split browser_webconsole_jsterm.js in multiple tests; r=Honza.

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/9b0cf7518d66