Closed Bug 1405377 Opened 2 years ago Closed 2 years ago
Recently closed tabs/windows subviews (accessible from the history subview) have a trailing separator
59 bytes, text/x-review-board-request
STR: 1. open library 2. open history 3. open recently closed tabs/windows ER: "Restore all tabs/windows" footer at the bottom, but nothing between the footer border and the last item AR: There's an additional separator above the footer's border that shouldn't be there.
Comment on attachment 8914863 [details] Bug 1405377 - remove trailing separator in recently closed tabs/windows subviews, https://reviewboard.mozilla.org/r/186126/#review191432 Agreed, this is the simplest fix. Thanks!
Attachment #8914863 - Flags: review?(mdeboer) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/ed7b92c9eca5 remove trailing separator in recently closed tabs/windows subviews, r=mikedeboer
Comment on attachment 8914863 [details] Bug 1405377 - remove trailing separator in recently closed tabs/windows subviews, Approval Request Comment [Feature/Bug causing the regression]: bug 1354533 [User impact if declined]: there's a weird extra line in the 'restore tabs' and 'restore windows' views accessible through library>history and the history widget [Is this code covered by automated tests?]: yes, but they don't seem to care about the separator [Has the fix been verified in Nightly?]: not yet [Needs manual test from QE? If yes, steps to reproduce]: yes: 1. open some tabs/windows to actual websites 2. close some of those tabs/windows 3. open library > history > recently closed tabs/windows expected: there's entries for the closed items, and a footer with a top border - but no separator-style line above the footer's border pre-patch: there's an extra separator-style line there for some reason. [List of other uplifts needed for the feature/fix]: n/a [Is the change risky?]: no [Why is the change risky/not risky?]: 1-line JS change, we have some tests for this code, the fix is well-understood, there's still significant beta runway, etc. etc. [String changes made/needed]: no
Attachment #8914863 - Flags: approval-mozilla-beta?
Comment on attachment 8914863 [details] Bug 1405377 - remove trailing separator in recently closed tabs/windows subviews, Recent regression, Beta57+
Attachment #8914863 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified fixed using the latest Nightly (2017-10-09) and Firefox Beta 57.0b6 on Windows 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.12
You need to log in before you can comment on or make changes to this bug.