Closed Bug 1405456 Opened 2 years ago Closed 2 years ago

Changing devtools theme should affect JSON Viewer immediately

Categories

(DevTools :: JSON Viewer, defect)

defect
Not set

Tracking

(firefox58 fixed)

RESOLVED FIXED
Firefox 58
Tracking Status
firefox58 --- fixed

People

(Reporter: Oriol, Assigned: Oriol)

Details

Attachments

(1 file)

Load data:application/json,123
Open devtools and change theme

Result: the JSON Viewer theme does not change unless the page is reloaded.
Expected: the theme changes immediately.
Assignee: nobody → oriol-bugzilla
Status: NEW → ASSIGNED
Comment on attachment 8918661 [details]
Bug 1405456 - Update JSON Viewer theme when the devtools theme changes.

https://reviewboard.mozilla.org/r/189488/#review195468

I like this, works great!

R+ assuming try is green.

Honza
Attachment #8918661 - Flags: review?(odvarko) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/21c6744ea8ed
Update JSON Viewer theme when the devtools theme changes. r=Honza
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/21c6744ea8ed
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Comment on attachment 8918661 [details]
Bug 1405456 - Update JSON Viewer theme when the devtools theme changes.

Looks reasonable to me.
R+
Honza
(In reply to Jan Honza Odvarko [:Honza] from comment #5)
> Looks reasonable to me.
> R+
> Honza

This bug was already fixed. Did you comment in the wrong bug?
(In reply to Oriol Brufau [:Oriol] from comment #6)
> This bug was already fixed. Did you comment in the wrong bug?
Yes, sorry, wrong bug.
Honza
I have reproduced this bug with Nightly 58.0a1 (2017-10-03) on Windows 10, 64 Bit!

This bug's fix is verified with Latest Beta!

Build ID  : 20171207170405
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
QA Whiteboard: [bugday-20171206]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.