1405519 - (AWS Only) Implement error pages (e.g., 403, 404, 500) for MDN untrusted domain (mdn.mozillademos.org)

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: File attachments, defect, P1)

Description

[Ryan Johnson (:rjohnson)]

What did you do?
================
Request a non-existent file attachment, for example:

https://stage-files.mdn.moz.works/files/12984233/web-font-example.png

What happened?
==============
Generates an internal server error due to the fact that it is unable to reverse the "home" URL when rendering the 404.html page:

http_app_kuma: 2017-10-03 16:45:21,928 django.request:ERROR Internal Server Error: /files/12984233/web-font-example.png: /usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py:256
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py", line 87, in get_exception_response
    response = callback(request, **param_dict)
  File "/usr/local/lib/python2.7/dist-packages/newrelic/hooks/framework_django.py", line 527, in wrapper
    return wrapped(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py", line 110, in _wrapped_view
    response = view_func(request, *args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/django/views/defaults.py", line 22, in page_not_found
    body = template.render(context, request)
  File "/usr/local/lib/python2.7/dist-packages/django_jinja/backend.py", line 106, in render
    return mark_safe(self.template.render(context))
  File "/usr/local/lib/python2.7/dist-packages/newrelic/api/function_trace.py", line 95, in dynamic_wrapper
    return wrapped(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/jinja2/environment.py", line 989, in render
    return self.environment.handle_exception(exc_info, True)
  File "/usr/local/lib/python2.7/dist-packages/jinja2/environment.py", line 754, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/app/jinja2/404.html", line 3, in top-level template code
    {% set styles = ('error-404',) %}
  File "/app/jinja2/base.html", line 18, in top-level template code
    <link rel="home" href="{{ url('home') }}">
  File "/app/kuma/core/templatetags/jinja_helpers.py", line 47, in url
    return reverse(viewname, args=args, kwargs=kwargs, locale=locale)
  File "/app/kuma/core/urlresolvers.py", line 67, in reverse
    prefix=prefix, current_app=current_app)
  File "/usr/local/lib/python2.7/dist-packages/newrelic/hooks/framework_django.py", line 624, in wrapper
    return execute(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/newrelic/hooks/framework_django.py", line 623, in execute
    return wrapped(viewname, *args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/django/core/urlresolvers.py", line 578, in reverse
    return force_text(iri_to_uri(resolver._reverse_with_prefix(view, prefix, *args, **kwargs)))
  File "/usr/local/lib/python2.7/dist-packages/django/core/urlresolvers.py", line 495, in _reverse_with_prefix
    (lookup_view_s, args, kwargs, len(patterns), patterns))
NoReverseMatch: Reverse for 'home' with arguments '()' and keyword arguments '{}' not found. 0 pattern(s) tried: []

What should have happened?
==========================
It should have at least returned a 404.

Is there anything else we should know?
======================================
This only applies to MDN in AWS. It does not manifest in SCL3.

Comment 1

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/000d9f11296e0a16c9c479e7d374296d58732fbd
bug 1405519: handle 403/404/500 errors when domain is untrusted

https://github.com/mozilla/kuma/commit/bec603a86dd6d46c6480713e46db48732e90f745
bug 1405519: Add err handlers for untrusted domain

https://github.com/mozilla/kuma/commit/87984cd46625405f5518c2e491caeff998e56f5f
Merge pull request #4454 from escattone/handle-untrusted-errors-1405519

bug 1405519: handle 403/404/500 errors when domain is untrusted

Comment 2

[John Whitlock [:jwhitlock]]

mdn.mozillademos.org moved to AWS, new 404 pages are active.