Closed Bug 1405539 Opened 7 years ago Closed 7 years ago

Add info doorhanger, collapsible sections and bug fixes to Activity Stream

Categories

(Firefox :: New Tab Page, enhancement)

Product:
Firefox
Component:
New Tab Page
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 58
Tracking Flags:
Tracking Status
firefox58 --- fixed

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

(Whiteboard: [export])

User Story

https://github.com/mozilla/activity-stream/compare/43726d353feb07b385dc3d7b0a5e903e54c975e2...fbbf9d84b9410c8dc80f7f19cc5b3f24984b668a

Attachments

(1 file)

Bug 1405539 - Add info doorhanger, collapsible sections and bug fixes to Activity Stream.
59 bytes, text/x-review-board-request
k88hudson
: review+
Details 
      No description provided.
Depends on: 1404261
Depends on: 1405296
Depends on: 1405300
User Story: (updated)
Depends on: 1406120
No longer depends on: 1404345
Summary: Add ... and bug fixes to Activity Stream → Add responsive bookmarking, info doorhanger and bug fixes to Activity Stream
Comment on attachment 8915766 [details]
Bug 1405539 - Add info doorhanger, collapsible sections and bug fixes to Activity Stream.

https://reviewboard.mozilla.org/r/186984/#review192054
Attachment #8915766 - Flags: review?(khudson) → review+
I needed to whitelist the panelarrow images in browser_parsable_css.js because we reference both but only one will actually load. Even if we had some os-specific css rules, the test would complain as it's still referenced. Alternatively, we package our own copy of the arrow…
Pushed by edilee@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b05a80fad5bc
Add responsive bookmarking, info doorhanger and bug fixes to Activity Stream. r=k88hudson
Backed out for frequently failing chrome-3's toolkit/components/extensions/test/mochitest/test_chrome_ext_downloads_saveAs.html on Windows debug:

https://hg.mozilla.org/integration/autoland/rev/73c1519225a0045a63102bad8e2961c76f3a9ead

See this push range: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&fromchange=5b1997aeaead8fc245f2f7d2a66aae3f0c5d170d&filter-searchStr=31b6b704d845158b1c6171e9a7828f346db861d6&tochange=73c1519225a0045a63102bad8e2961c76f3a9ead
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=135374751&repo=autoland

15:51:38     INFO -  647 INFO SpawnTask.js | Entering test test_downloads_saveAs
15:51:38     INFO -  648 INFO Extension loaded
15:51:38     INFO -  Buffered messages logged at 15:51:35
15:51:38     INFO -  649 INFO TEST-PASS | toolkit/components/extensions/test/mochitest/test_chrome_ext_downloads_saveAs.html | downloads.download() works with saveAs
15:51:38     INFO -  650 INFO TEST-PASS | toolkit/components/extensions/test/mochitest/test_chrome_ext_downloads_saveAs.html | the file exists.
15:51:38     INFO -  651 INFO TEST-PASS | toolkit/components/extensions/test/mochitest/test_chrome_ext_downloads_saveAs.html | downloaded file is the correct size
15:51:38     INFO -  Buffered messages logged at 15:51:37
15:51:38     INFO -  652 INFO TEST-PASS | toolkit/components/extensions/test/mochitest/test_chrome_ext_downloads_saveAs.html | downloads.download() works with saveAs and uniquify
15:51:38     INFO -  653 INFO TEST-PASS | toolkit/components/extensions/test/mochitest/test_chrome_ext_downloads_saveAs.html | the file exists.
15:51:38     INFO -  654 INFO TEST-PASS | toolkit/components/extensions/test/mochitest/test_chrome_ext_downloads_saveAs.html | downloaded file is the correct size
15:51:38     INFO -  655 INFO TEST-PASS | toolkit/components/extensions/test/mochitest/test_chrome_ext_downloads_saveAs.html | download rejected if the user cancels the dialog
15:51:38     INFO -  656 INFO TEST-PASS | toolkit/components/extensions/test/mochitest/test_chrome_ext_downloads_saveAs.html | with the correct message
15:51:38     INFO -  Buffered messages finished
15:51:38    ERROR -  657 INFO TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_chrome_ext_downloads_saveAs.html | unique file not left after SaveAs canceled.
15:51:38     INFO -  test_downloads_saveAs@chrome://mochitests/content/chrome/toolkit/components/extensions/test/mochitest/test_chrome_ext_downloads_saveAs.html:111:3
15:51:38     INFO -  async*add_task/</<@chrome://mochikit/content/tests/SimpleTest/SpawnTask.js:298:21
15:51:38     INFO -  onFulfilled@chrome://mochikit/content/tests/SimpleTest/SpawnTask.js:69:15
15:51:38     INFO -  promise callback*next@chrome://mochikit/content/tests/SimpleTest/SpawnTask.js:104:45
15:51:38     INFO -  onFulfilled@chrome://mochikit/content/tests/SimpleTest/SpawnTask.js:73:7
15:51:38     INFO -  co/<@chrome://mochikit/content/tests/SimpleTest/SpawnTask.js:58:5
15:51:38     INFO -  co@chrome://mochikit/content/tests/SimpleTest/SpawnTask.js:54:10
15:51:38     INFO -  setTimeout handler*SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:676:12
15:51:38     INFO -  add_task@chrome://mochikit/content/tests/SimpleTest/SpawnTask.js:271:7
15:51:38     INFO -  @chrome://mochitests/content/chrome/toolkit/components/extensions/test/mochitest/test_chrome_ext_downloads_saveAs.html:21:1
Flags: needinfo?(edilee)
User Story: (updated)
Flags: needinfo?(edilee)
Summary: Add responsive bookmarking, info doorhanger and bug fixes to Activity Stream → Add info doorhanger, collapsible sections and bug fixes to Activity Stream
This seems to also have caused these failures in tc-M(bc2) on Windows 7 debug:
https://treeherder.mozilla.org/logviewer.html#?job_id=135401797&repo=autoland

18:37:52     INFO -  517 INFO TEST-START | browser/extensions/onboarding/test/browser/browser_onboarding_notification_5.js
18:37:52     INFO -  GECKO(868) | ++DOCSHELL 2ACCAC00 == 13 [pid = 868] [id = {b815aaf2-a843-4c78-9f23-dff91f87d96d}]
18:37:52     INFO -  GECKO(868) | ++DOMWINDOW == 62 (2B7C3400) [pid = 868] [serial = 128] [outer = 00000000]
18:37:52     INFO -  GECKO(868) | ++DOMWINDOW == 63 (2B7CB800) [pid = 868] [serial = 129] [outer = 2B7C3400]
18:37:52     INFO -  GECKO(868) | ++DOMWINDOW == 64 (2BD2EC00) [pid = 868] [serial = 130] [outer = 2B7C3400]
18:37:52     INFO -  GECKO(868) | [868, Main Thread] WARNING: stylo: Web Components not supported yet: file z:/build/build/src/dom/base/nsDocument.cpp, line 6445
18:37:52     INFO -  GECKO(868) | [868, Main Thread] WARNING: stylo: Web Components not supported yet: file z:/build/build/src/dom/base/nsDocument.cpp, line 6445
18:37:52     INFO -  GECKO(868) | ++DOMWINDOW == 65 (2BD36C00) [pid = 868] [serial = 131] [outer = 2B7C3400]
18:37:52     INFO -  GECKO(868) | [868, Main Thread] WARNING: stylo: Web Components not supported yet: file z:/build/build/src/dom/base/nsDocument.cpp, line 6445
18:37:52     INFO -  GECKO(868) | [868, Main Thread] WARNING: stylo: Web Components not supported yet: file z:/build/build/src/dom/base/nsDocument.cpp, line 6445
18:37:52     INFO -  GECKO(868) | [868, Main Thread] WARNING: attempt to modify an immutable nsStandardURL: file z:/build/build/src/netwerk/base/nsStandardURL.cpp, line 1827
18:37:53     INFO -  GECKO(868) | console.error: UITour:
18:37:53     INFO -  GECKO(868) |   Message: [Exception... "Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsIMessageSender.sendAsyncMessage]"  nsresult: "0xc1f30001 (NS_ERROR_NOT_INITIALIZED)"  location: "JS frame :: resource:///modules/UITour.jsm :: sendPageCallback :: line 961"  data: no]
18:37:53     INFO -  GECKO(868) |   Stack:
18:37:53     INFO -  GECKO(868) |     sendPageCallback@resource:///modules/UITour.jsm:961:5
18:37:53     INFO -  GECKO(868) | getAppInfo/<@resource:///modules/UITour.jsm:1687:7
18:37:53     INFO -  GECKO(868) | async*getAppInfo@resource:///modules/UITour.jsm:1637:6
18:37:53     INFO -  GECKO(868) | getConfiguration@resource:///modules/UITour.jsm:1579:9
18:37:53     INFO -  GECKO(868) | onPageEvent@resource:///modules/UITour.jsm:539:9
18:37:53     INFO -  GECKO(868) | @jar:file:///Z:/task_1507314222/build/application/firefox/browser/omni.ja!/components/nsBrowserGlue.js:2956:3
18:37:54     INFO -  GECKO(868) | ++DOMWINDOW == 66 (2DEBC400) [pid = 868] [serial = 132] [outer = 2B7C3400]
18:37:54     INFO -  GECKO(868) | [868, Main Thread] WARNING: stylo: Web Components not supported yet: file z:/build/build/src/dom/base/nsDocument.cpp, line 6445
18:37:54     INFO -  GECKO(868) | [868, Main Thread] WARNING: stylo: Web Components not supported yet: file z:/build/build/src/dom/base/nsDocument.cpp, line 6445
18:37:54     INFO -  GECKO(868) | [868, Main Thread] WARNING: attempt to modify an immutable nsStandardURL: file z:/build/build/src/netwerk/base/nsStandardURL.cpp, line 1827
18:37:55     INFO -  TEST-INFO | started process screenshot
18:37:55     INFO -  TEST-INFO | screenshot: exit 0
18:37:55     INFO -  Buffered messages logged at 18:37:52
18:37:55     INFO -  518 INFO Entering test bound test_finish_tour_notifcations_after_total_max_life_time
18:37:55     INFO -  Buffered messages logged at 18:37:53
18:37:55     INFO -  519 INFO TEST-PASS | browser/extensions/onboarding/test/browser/browser_onboarding_notification_5.js | Should load onboarding overlay - true == true -
18:37:55     INFO -  Buffered messages logged at 18:37:54
18:37:55     INFO -  520 INFO TEST-PASS | browser/extensions/onboarding/test/browser/browser_onboarding_notification_5.js | Should open tour notification - true == true -
18:37:55     INFO -  Buffered messages logged at 18:37:55
18:37:55     INFO -  521 INFO TEST-PASS | browser/extensions/onboarding/test/browser/browser_onboarding_notification_5.js | Should load onboarding overlay - true == true -
18:37:55     INFO -  522 INFO TEST-PASS | browser/extensions/onboarding/test/browser/browser_onboarding_notification_5.js | Should update the pref of browser.onboarding.notification.finished -
18:37:55     INFO -  523 INFO TEST-PASS | browser/extensions/onboarding/test/browser/browser_onboarding_notification_5.js | Should update the pref of browser.onboarding.state -
18:37:55     INFO -  524 INFO TEST-PASS | browser/extensions/onboarding/test/browser/browser_onboarding_notification_5.js | Should display the watermark onboarding icon - true == true -
18:37:55     INFO -  Buffered messages finished
18:37:55    ERROR -  525 INFO TEST-UNEXPECTED-FAIL | browser/extensions/onboarding/test/browser/browser_onboarding_notification_5.js | A promise chain failed to handle a rejection: Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsIMessageSender.sendAsyncMessage] - stack: null
18:37:55     INFO -  Rejection date: Fri Oct 06 2017 18:37:53 GMT+0000 (Coordinated Universal Time) - false == true - JS frame :: resource://testing-common/PromiseTestUtils.jsm :: assertNoUncaughtRejections :: line 265
18:37:55     INFO -  Stack trace:
18:37:55     INFO -      resource://testing-common/PromiseTestUtils.jsm:assertNoUncaughtRejections:265
18:37:55     INFO -      chrome://mochikit/content/browser-test.js:Tester_execTest/<:829
18:37:55     INFO -      Tester_execTest@chrome://mochikit/content/browser-test.js:798:9
18:37:55     INFO -      Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:697:9
18:37:55     INFO -      SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59
andreio, comment 11 might help track down the other failures? Onboarding is a bit more related than the other mysterious failures.
Flags: needinfo?(andrei.br92)
I ended up reverting the first commit of the export to avoid all the test failures: https://github.com/mozilla/activity-stream/commit/0acee91f8ea814365553593cf756e478071b2541

Reopened https://github.com/mozilla/activity-stream/issues/3131
Pushed by edilee@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/8095eff05ac9
Add info doorhanger, collapsible sections and bug fixes to Activity Stream. r=k88hudson
https://hg.mozilla.org/mozilla-central/rev/8095eff05ac9
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
No longer depends on: 1404261
Blocks: 1407657
The entries added in this bug to browser_parsable_css.js will be removed by bug 1408121.
Flags: needinfo?(andrei.br92)
Assignee: nobody → edilee
Whiteboard: [export]
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: