Open Bug 1405553 Opened 8 years ago Updated 3 years ago

stylo: Add a method for setting RefPtr<nsIAtom> from Atom

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Tracking Flags:
Tracking Status
firefox57 --- wontfix
firefox58 --- wontfix
firefox59 --- ?

People

(Reporter: xidorn, Unassigned)

Details

There are some places where we want to assign a RefPtr<nsIAtom> with an Atom, but we have to invoke independent FFI for that. Those FFI functions currently include Gecko_nsStyleFont_SetLang and Gecko_SetAnimationName (being added in bug 1329169). We may have more in the list in the future. That both inefficient (because of an extra FFI call) and less type-safe (because we don't have mechanism to express addrefed nsIAtom). And apparently, cause redundant code. We should be able to add a method for structs::RefPtr<nsIAtom> in sugar/refptr.rs to replace those functions.
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.