Migrate browser_webconsole_netlogging_reset_filter.js to the new frontend

RESOLVED FIXED in Firefox 59

Status

defect
P1
normal
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: nchevobbe, Assigned: jdescottes)

Tracking

(Blocks 1 bug)

Trunk
Firefox 59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 wontfix, firefox58 wontfix, firefox59 fixed)

Details

(Whiteboard: [newconsole-mvp])

Attachments

(1 attachment)

No description provided.
Priority: -- → P3
Priority: P3 → P2
Whiteboard: [newconsole-mvp]
try https://treeherder.mozilla.org/#/jobs?repo=try&revision=370254410aab906be6bc9f9f181331cb89b7b995
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment on attachment 8941018 [details]
Bug 1405636 - enable and rename browser_webconsole_netlogging_reset_filter.js;

https://reviewboard.mozilla.org/r/211314/#review217778

Looks good and passes locally on Win10

R+ assuming try is green and the little typo is fixed.

Thanks Julian for the patch!
Honza

::: devtools/client/webconsole/new-console-output/test/mochitest/head.js:463
(Diff revision 1)
> + * @param {Object} toolbox
> + * @param {Object} hud
> + * @param {String} url
> + *        URL of the request as logged in the netmonitor.
> + * @param {String} urlInConsole
> + *        (optional) USe if the logged URL in webconsole is different from the real URL.

nit typo: USe -> Use
Attachment #8941018 - Flags: review?(odvarko) → review+
Comment on attachment 8941018 [details]
Bug 1405636 - enable and rename browser_webconsole_netlogging_reset_filter.js;

https://reviewboard.mozilla.org/r/211314/#review217778

Thanks for the review Honza! Fixed the typo and try was green. Landing.
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5f6417128acb
enable and rename browser_webconsole_netlogging_reset_filter.js;r=Honza
https://hg.mozilla.org/mozilla-central/rev/5f6417128acb
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.