Unquoted variable in regexp in globals.pl.

RESOLVED FIXED in Bugzilla 2.16

Status

()

Bugzilla
Bugzilla-General
RESOLVED FIXED
16 years ago
5 years ago

People

(Reporter: CodeMachine, Assigned: myk)

Tracking

2.15
Bugzilla 2.16

Details

Attachments

(1 attachment)

(Reporter)

Description

16 years ago
In GetOutputFormats in globals.pl the following line appears:

  if ($file =~ /^$script-(.+)\.(.+)\.(tmpl)$/) {

$script should be quoted using \Q and \E.  This is probably not a big issue as
the possible values are hardcoded into Bugzilla, and the regular expression
operators probably wouldn't appear (but what about '.'?), but it should be fixed.

Comment 1

16 years ago
Created attachment 81463 [details] [diff] [review]
patch

Like this?

Updated

16 years ago
Keywords: patch, review
(Assignee)

Comment 2

16 years ago
Comment on attachment 81463 [details] [diff] [review]
patch

Works, trivial, 2xr=myk
Attachment #81463 - Flags: review+
Fixed. Thanks :-)

Checking in globals.pl;
/cvsroot/mozilla/webtools/bugzilla/globals.pl,v  <--  globals.pl
new revision: 1.165; previous revision: 1.164
done

Gerv
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Bugzilla 2.16
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.