Closed Bug 1405641 Opened 2 years ago Closed 2 years ago

Migrate browser_webconsole_output_copy_newlines.js to the new frontend

Categories

(DevTools :: Console, defect, P1)

defect

Tracking

(firefox57 wontfix, firefox60 fixed)

RESOLVED FIXED
Firefox 60
Tracking Status
firefox57 --- wontfix
firefox60 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

(Whiteboard: [newconsole-mvp])

Attachments

(1 file)

This could be done by adding a test case to browser_webconsole_output_copy_newlines.js to test copying multiple lines at the same time.
Priority: -- → P3
Priority: P3 → P2
Whiteboard: [newconsole-mvp]
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment on attachment 8949811 [details]
Bug 1405641 - Enable browser_webconsole_output_copy_newlines.js in new console frontend; .

https://reviewboard.mozilla.org/r/219116/#review224894

Looks good thanks! 

Let's just have a try run on linux32 debug to check the time this test is taking.

::: devtools/client/webconsole/new-console-output/test/mochitest/browser.ini
(Diff revision 1)
>  [browser_webconsole_output_copy.js]
>  subsuite = clipboard
>  [browser_webconsole_output_copy_newlines.js]
>  subsuite = clipboard
> -skip-if = true #	Bug 1405641
> -# old console skip-if = (os == 'linux' && bits == 32 && debug) # bug 1328915, disable linux32 debug devtools for timeouts

So we are no longer running devtools tests on linux32 debug, but this one runs in the cl chunk, and I believe this is still executed on linux32 debug. 

Can we get a try run on this platform to see the running time of the test?

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_output_copy_newlines.js:33
(Diff revision 1)
> +  const range = document.createRange();
> +  range.selectNodeContents(output);
> +  selection.removeAllRanges();
> +  selection.addRange(range);
>  
> -  goUpdateCommand("cmd_copy");
> +  await waitForClipboardPromise(

Can we add an info() here to explain we are going to wait on the clipboard to contain the text corresponding to all the selected lines?

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_output_copy_newlines.js:41
(Diff revision 1)
> -         "first message text does not include 'bug916997b'");
> -    },
> -    () => {
> -      info("last clipboard value: '" + clipboardValue + "'");
> -    });
>  });

eslint: missing newline at the end of file
Attachment #8949811 - Flags: review?(jdescottes) → review+
Thanks fir the review Julian. I addressed the comments and pushed to TRY with a linux(32) job, and everything was fine. So let's push this :)
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/84ef4e4f8804
Enable browser_webconsole_output_copy_newlines.js in new console frontend; r=jdescottes.
https://hg.mozilla.org/mozilla-central/rev/84ef4e4f8804
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.