1405647 - Migrate browser_webconsole_split_escape_key.js to the new frontend

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

The variable view part can be completely removed

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1405647 - enable browser_webconsole_split_escape_key.js;

Review commit: https://reviewboard.mozilla.org/r/219112/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/219112/

Comment 2

[Julian Descottes [:jdescottes]]

This one is significantly rewritten because we removed the variables-view related parts and migrated to add_test + async functions. Probably easier to review by reading the test as it is rather than looking at the diff. 

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=931739b6b76fe52ea0e63617f654c61220f33112

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8949805 [details]
Bug 1405647 - enable browser_webconsole_split_escape_key.js;

https://reviewboard.mozilla.org/r/219112/#review226024

Looks a lot cleaner now and is green locally,
R+
Thanks,
Honza

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_split_escape_key.js:28
(Diff revision 1)
> -     results[0].matchedProp.focus();
> -     EventUtils.synthesizeKey("VK_RETURN", variablesView.window);
> -   }
>  
> -   function showAutoCompletePopoup() {
> -     let onPopupShown = jsterm.autocompletePopup.once("popup-opened");
> +  let onPopupShown = jsterm.autocompletePopup.once("popup-opened");

nit: you might utilize the `popup` variable, which is declared a few lines later.

Comment 4

[Julian Descottes [:jdescottes]]

Comment on attachment 8949805 [details]
Bug 1405647 - enable browser_webconsole_split_escape_key.js;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/219112/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd43c8ae2714
enable browser_webconsole_split_escape_key.js;r=Honza

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/cd43c8ae2714