Closed Bug 1405647 Opened 3 years ago Closed 2 years ago

Migrate browser_webconsole_split_escape_key.js to the new frontend

Categories

(DevTools :: Console, enhancement, P1)

enhancement

Tracking

(firefox60 fixed)

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 --- fixed

People

(Reporter: nchevobbe, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

(Whiteboard: [newconsole-mvp])

Attachments

(1 file)

The variable view part can be completely removed
Priority: -- → P3
Priority: P3 → P2
Whiteboard: [newconsole-mvp]
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Priority: P2 → P1
This one is significantly rewritten because we removed the variables-view related parts and migrated to add_test + async functions. Probably easier to review by reading the test as it is rather than looking at the diff. 

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=931739b6b76fe52ea0e63617f654c61220f33112
Comment on attachment 8949805 [details]
Bug 1405647 - enable browser_webconsole_split_escape_key.js;

https://reviewboard.mozilla.org/r/219112/#review226024

Looks a lot cleaner now and is green locally,
R+
Thanks,
Honza

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_split_escape_key.js:28
(Diff revision 1)
> -     results[0].matchedProp.focus();
> -     EventUtils.synthesizeKey("VK_RETURN", variablesView.window);
> -   }
>  
> -   function showAutoCompletePopoup() {
> -     let onPopupShown = jsterm.autocompletePopup.once("popup-opened");
> +  let onPopupShown = jsterm.autocompletePopup.once("popup-opened");

nit: you might utilize the `popup` variable, which is declared a few lines later.
Attachment #8949805 - Flags: review?(odvarko) → review+
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cd43c8ae2714
enable browser_webconsole_split_escape_key.js;r=Honza
https://hg.mozilla.org/mozilla-central/rev/cd43c8ae2714
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.