1405652 - Migrate browser_webconsole_view_source.js to the new frontend

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1405652 - Enable browser_webconsole_view_source.js in new console frontend; .

Review commit: https://reviewboard.mozilla.org/r/191488/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/191488/

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8920486 [details]
Bug 1405652 - Enable browser_webconsole_view_source.js in new console frontend; .

https://reviewboard.mozilla.org/r/191488/#review196814

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_view_source.js:32
(Diff revision 1)
> -  let tab = yield onTabOpen;
>    ok(true, "the view source tab was opened in response to clicking the location node");
> -  gBrowser.removeTab(tab);
>  });
> +
> +async function waitForTabLoad() {

I think `BrowserTestUtils.waitForNewTab(gBrowser, null, true)` can replace this function: https://searchfox.org/mozilla-central/source/testing/mochitest/BrowserTestUtils/BrowserTestUtils.jsm?from=BrowserTestUtils.jsm#391

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Brian Grinstead [:bgrins] from comment #2)
> Comment on attachment 8920486 [details]
> Bug 1405652 - Enable browser_webconsole_view_source.js in new console
> frontend; .
> 
> https://reviewboard.mozilla.org/r/191488/#review196814
> 
> :::
> devtools/client/webconsole/new-console-output/test/mochitest/
> browser_webconsole_view_source.js:32
> (Diff revision 1)
> > -  let tab = yield onTabOpen;
> >    ok(true, "the view source tab was opened in response to clicking the location node");
> > -  gBrowser.removeTab(tab);
> >  });
> > +
> > +async function waitForTabLoad() {
> 
> I think `BrowserTestUtils.waitForNewTab(gBrowser, null, true)` can replace
> this function:
> https://searchfox.org/mozilla-central/source/testing/mochitest/
> BrowserTestUtils/BrowserTestUtils.jsm?from=BrowserTestUtils.jsm#391

works like a charm, thanks !

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8920486 [details]
Bug 1405652 - Enable browser_webconsole_view_source.js in new console frontend; .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/191488/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/810825b3ce19
Enable browser_webconsole_view_source.js in new console frontend; r=bgrins.

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/810825b3ce19