Closed Bug 1405669 Opened 2 years ago Closed 2 years ago

[Pointer Event] Avoid creating temporarily variable when serializing WidgetPointerHelper

Categories

(Core :: DOM: Events, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: stone, Assigned: stone)

Details

Attachments

(2 files, 1 obsolete file)

No description provided.
Assignee: nobody → sshih
Comment on attachment 8915518 [details]
Bug 1405669 - [Pointer Event] Avoid creating temporarily variable when serializing WidgetPointerHelper.

https://reviewboard.mozilla.org/r/186732/#review191778

Nice! (I wonder, this kind of bugs will be checked with MozReview's static analysis?)
Attachment #8915518 - Flags: review?(masayuki) → review+
(In reply to Masayuki Nakano [:masayuki] (JST, +0900) from comment #4)
> Comment on attachment 8915518 [details]
> Bug 1405669 - [Pointer Event] Avoid creating temporarily variable when
> serializing WidgetPointerHelper.
> 
> https://reviewboard.mozilla.org/r/186732/#review191778
> 
> Nice! (I wonder, this kind of bugs will be checked with MozReview's static
> analysis?)

It seems not. I tried to submit a review draft with the similar problem, didn't find a warning or something about it.
(In reply to Ming-Chou Shih [:stone] from comment #5)
> (In reply to Masayuki Nakano [:masayuki] (JST, +0900) from comment #4)
> > Nice! (I wonder, this kind of bugs will be checked with MozReview's static
> > analysis?)
> 
> It seems not. I tried to submit a review draft with the similar problem,
> didn't find a warning or something about it.

Sigh.
Pushed by sshih@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/022f5922d176
[Pointer Event] Avoid creating temporarily variable when serializing WidgetPointerHelper. r=masayuki
https://hg.mozilla.org/mozilla-central/rev/022f5922d176
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.