Closed Bug 1405697 Opened 7 years ago Closed 7 years ago

Move channel based MediaResources out of MediaResource.h

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

Product:
Core
Component:
Audio/Video: Playback
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla58
Tracking Flags:
Tracking Status
firefox58 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

References

Details

Attachments

(8 files)

Bug 1405697 - Move MediaChannelStatistics to its own file.
59 bytes, text/x-review-board-request
jwwang
: review+
Details
Bug 1405697 - Move ChannelSuspendAgent to ChannelMediaResource.h.
59 bytes, text/x-review-board-request
jwwang
: review+
Details
Bug 1405697 - Move HTTP_REQUESTED_RANGE_NOT_SATISFIABLE_CODE to the file it's used in.
59 bytes, text/x-review-board-request
jwwang
: review+
Details
Bug 1405697 - Move SEEK_VS_READ_THRESHOLD to where it's used.
59 bytes, text/x-review-board-request
jwwang
: review+
Details
Bug 1405697 - Move BaseMediaResource declaration to its own file.
59 bytes, text/x-review-board-request
jwwang
: review+
Details
Bug 1405697 - Move BaseMediaResource implementation into cpp file.
59 bytes, text/x-review-board-request
jwwang
: review+
Details
Bug 1405697 - Move MediaResourceIndex implementation to MediaResource.cpp.
59 bytes, text/x-review-board-request
jwwang
: review+
Details
Bug 1405697 - Move MediaPrefs include from MediaResource.h into cpp file.
59 bytes, text/x-review-board-request
jwwang
: review+
Details 
We need to reimplement a MediaResource for Servo, so to facilitate that, I need to move the definitions related to Necko channels out of MediaResource.h into their own headers, as we don't want to be including Necko in Servo.
Comment on attachment 8915259 [details]
Bug 1405697 - Move MediaChannelStatistics to its own file.

https://reviewboard.mozilla.org/r/186482/#review191760
Attachment #8915259 - Flags: review?(jwwang) → review+
Comment on attachment 8915260 [details]
Bug 1405697 - Move ChannelSuspendAgent to ChannelMediaResource.h.

https://reviewboard.mozilla.org/r/186484/#review191762
Attachment #8915260 - Flags: review?(jwwang) → review+
Comment on attachment 8915261 [details]
Bug 1405697 - Move HTTP_REQUESTED_RANGE_NOT_SATISFIABLE_CODE to the file it's used in.

https://reviewboard.mozilla.org/r/186486/#review191764
Attachment #8915261 - Flags: review?(jwwang) → review+
Comment on attachment 8915262 [details]
Bug 1405697 - Move SEEK_VS_READ_THRESHOLD to where it's used.

https://reviewboard.mozilla.org/r/186488/#review191766
Attachment #8915262 - Flags: review?(jwwang) → review+
Comment on attachment 8915263 [details]
Bug 1405697 - Move BaseMediaResource declaration to its own file.

https://reviewboard.mozilla.org/r/186490/#review191768

::: dom/media/BaseMediaResource.h:20
(Diff revision 3)
> +
> +class nsIPrincipal;
> +
> +namespace mozilla {
> +
> +class BaseMediaResource : public MediaResource

It would be nice to preserve the history when moving code.

::: dom/media/MediaResource.h:15
(Diff revision 3)
> -#include "MediaResourceCallback.h"
> -#include "mozilla/Atomics.h"
>  #include "mozilla/Attributes.h"
> -#include "mozilla/TimeStamp.h"
> +#include "mozilla/GuardObjects.h"
>  #include "mozilla/UniquePtr.h"
> +#include "nsISeekableStream.h"

I think this is used by FileMediaResource only.
Attachment #8915263 - Flags: review?(jwwang) → review+
Comment on attachment 8915264 [details]
Bug 1405697 - Move BaseMediaResource implementation into cpp file.

https://reviewboard.mozilla.org/r/186492/#review191770
Attachment #8915264 - Flags: review?(jwwang) → review+
Comment on attachment 8915265 [details]
Bug 1405697 - Move MediaResourceIndex implementation to MediaResource.cpp.

https://reviewboard.mozilla.org/r/186496/#review191772
Attachment #8915265 - Flags: review?(jwwang) → review+
Comment on attachment 8915489 [details]
Bug 1405697 - Move MediaPrefs include from MediaResource.h into cpp file.

https://reviewboard.mozilla.org/r/186706/#review191774

Comfortable level has been increased.
Attachment #8915489 - Flags: review?(jwwang) → review+
(In reply to JW Wang [:jwwang] [:jw_wang] from comment #27)
> ::: dom/media/MediaResource.h:15
> (Diff revision 3)
> > -#include "MediaResourceCallback.h"
> > -#include "mozilla/Atomics.h"
> >  #include "mozilla/Attributes.h"
> > -#include "mozilla/TimeStamp.h"
> > +#include "mozilla/GuardObjects.h"
> >  #include "mozilla/UniquePtr.h"
> > +#include "nsISeekableStream.h"
> 
> I think this is used by FileMediaResource only.

MediaResourceIndex::Seek() uses nsISeekableStream defines.
Comment on attachment 8915263 [details]
Bug 1405697 - Move BaseMediaResource declaration to its own file.

https://reviewboard.mozilla.org/r/186490/#review191768

> It would be nice to preserve the history when moving code.

Good idea, done. Thanks!
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/44b026781b82
Move MediaChannelStatistics to its own file. r=jwwang
https://hg.mozilla.org/integration/autoland/rev/62643787da2b
Move ChannelSuspendAgent to ChannelMediaResource.h. r=jwwang
https://hg.mozilla.org/integration/autoland/rev/d626833c3f4c
Move HTTP_REQUESTED_RANGE_NOT_SATISFIABLE_CODE to the file it's used in. r=jwwang
https://hg.mozilla.org/integration/autoland/rev/34e8c0b24dda
Move SEEK_VS_READ_THRESHOLD to where it's used. r=jwwang
https://hg.mozilla.org/integration/autoland/rev/a27f0f4180ef
Move BaseMediaResource declaration to its own file. r=jwwang
https://hg.mozilla.org/integration/autoland/rev/fb6818a58e11
Move BaseMediaResource implementation into cpp file. r=jwwang
https://hg.mozilla.org/integration/autoland/rev/24f895e73649
Move MediaResourceIndex implementation to MediaResource.cpp. r=jwwang
https://hg.mozilla.org/integration/autoland/rev/c82b0e52307c
Move MediaPrefs include from MediaResource.h into cpp file. r=jwwang
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: