Closed
Bug 1405709
Opened 7 years ago
Closed 7 years ago
missing await in browser.pkcs11 test suite
Categories
(WebExtensions :: Untriaged, enhancement, P3)
Tracking
(firefox58 fixed)
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: wouter, Assigned: wouter)
Details
Attachments
(1 file)
While reviewing the file test_pkcs11_management.js added in bug 1357391 for inspiration for my own PKCS#11 management add-on, I noticed that I forgot one "await" in the test suite. The result is that there will be an assertTrue() on a Promise (which will always be successful) rather than on its resolved result. This shouldn't cause the test suite to succeed when it shouldn't, because if the module isn't successfully loaded then the next batch of tests that try to use it will fail, but it's confusing and not proper.
Assignee | ||
Updated•7 years ago
|
Summary: missing await → missing await in browser.pkcs11 test suite
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8915171 [details] Bug 1405709 - Add missing await to browser.pkcs11 test suite https://reviewboard.mozilla.org/r/186424/#review191970
Attachment #8915171 -
Flags: review?(tomica) → review+
Updated•7 years ago
|
Assignee: nobody → w
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/f5d73b59a8da Add missing await to browser.pkcs11 test suite r=zombie
Keywords: checkin-needed
Updated•7 years ago
|
Priority: -- → P3
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f5d73b59a8da
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Comment 5•7 years ago
|
||
Thanks for the patch, :wouter! Your contribution has been added to the add-ons recognition wiki: https://wiki.mozilla.org/Add-ons/Contribute/Recognition#October_2017 If you'd like to set up a profile on mozillians.org, I'd be happy to vouch for you. Welcome onboard!
Comment 6•6 years ago
|
||
Is manual testing required on this bug? If Yes, please provide some STR and the proper webextension(if required), if No set the “qe-verify-“ flag.
Flags: needinfo?(w)
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•