59 bytes, text/x-review-board-request
While reviewing the file test_pkcs11_management.js added in bug 1357391 for inspiration for my own PKCS#11 management add-on, I noticed that I forgot one "await" in the test suite. The result is that there will be an assertTrue() on a Promise (which will always be successful) rather than on its resolved result. This shouldn't cause the test suite to succeed when it shouldn't, because if the module isn't successfully loaded then the next batch of tests that try to use it will fail, but it's confusing and not proper.
Summary: missing await → missing await in browser.pkcs11 test suite
Comment on attachment 8915171 [details] Bug 1405709 - Add missing await to browser.pkcs11 test suite https://reviewboard.mozilla.org/r/186424/#review191970
Attachment #8915171 - Flags: review?(tomica) → review+
Assignee: nobody → w
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/f5d73b59a8da Add missing await to browser.pkcs11 test suite r=zombie
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Thanks for the patch, :wouter! Your contribution has been added to the add-ons recognition wiki: https://wiki.mozilla.org/Add-ons/Contribute/Recognition#October_2017 If you'd like to set up a profile on mozillians.org, I'd be happy to vouch for you. Welcome onboard!
Is manual testing required on this bug? If Yes, please provide some STR and the proper webextension(if required), if No set the “qe-verify-“ flag.
Added "qe-verify-" flag (test-only change).
Flags: needinfo?(w) → qe-verify-
You need to log in before you can comment on or make changes to this bug.