1405716 - Refine logic for showing/hiding Reader Mode FAB

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Reader View, defect, P3)

Description

[Mark]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13) AppleWebKit/604.1.38 (KHTML, like Gecko) Version/11.0 Safari/604.1.38

Steps to reproduce:

Enter Reader mode on Firefox Android 57 or Nightly 58 and scroll slowly.


Actual results:

The Floating Action Button has a hair trigger. Even the slightest downward scroll (couple of pixels) will bring it up. Sometimes the FAB appears after I do a slow upward scroll, I guess because my finger ends with a tiny (eg 1 pixel) downward scroll.

The FAB hangs around indefinitely, it does not auto hide.


Expected results:

(1) The FAB seems to appear too easily, could it require a larger scroll movement to invoke it, I don't remember this problem pre-Photon???

(2) could the FAB auto-hide after a few seconds, it's annoying to have to scroll to get rid of it.

Comment 1

[Jan Henning [:JanH]]

1. That change isn't Photon-related.
2. You don't remember it because we didn't use to hide the button at all before bug 1278704 was finally fixed for Firefox 56, although...
3. We have been using the same logic to dim Android's software buttons and the status bar for a long time already.


That said, your suggestions do seem like a nice idea. Bug 1278704 should give a clue for where to implement this...

Comment 2

[Mark]

Re 2 - aha.     I think that tells me that I find the FAB flashing on and off more irritating than the FAB continually present :( sorry. It does seem to flash on and off a lot with slow up/down swipes.

I've nothing against the FAB but it does seem very skittish ATM.

cheers now & thanks

Comment 3

[Nevin Chen(Not active on Bugzilla)]

Please help advise:)

Comment 4

[Carol Huang [:Carol]]

I'll leave this FAB behavior question to Jack :) thanks!

Comment 5

[Jack Lin[:jacklin]]

I am wondering how many users would use this FAB when reader mode is on? How often? and When? For me, it's a little bit like settings and won't use it often. If we have data and know just few people use it, maybe we can redesign this feature. 

But for current design, I referred to Firefox Focus, maybe we could use similar behavior - After show complete awesome bar then show FAB and system status bar on the top. So when users scroll down slightly, FAB will not be displayed until awesome bar be shown completely. It might reduce reading disturbance.

What do you think?

Comment 6

[Jan Henning [:JanH]]

Fixing this for 57 is out of the question and even 58 might be doubtful.

Linking this to the Awesomebar doesn't sound like a bad idea, though.

Comment 7

[Mark]

I know it might take a while but I thought I'd make my comments re linking to the Awesomebar:- I think that would be fine but I don't think it needs to be complicated.

There are two funny behaviours with the current FAB

(1) even a very small drag downwards shows the FAB

(2) if a short drag causes the Awesomebar to snap itself into or out of view, the FAB toggles such that FAB visibility = not(Awesomebar Visibility). I've attached a video of behaviour 2 just for fun. It's odd.

I think all you need to do is kill behaviour (2) and change behaviour (1) so that there is a threshold on the down drag of circa one line of text.

Personally I don't use the FAB, I used it once to set the text size but not since then. I think more features (eg margins) might come to the FAB, but I still will only use them once - set and forget. Google says a FAB is for a "promoted action" and I'm not sure setting the font size is a "promoted action" ;)

Video attached of behaviour (2) just to (hopefully) entertain you.

Thanks for your interest.

Comment 8

[Mark]

Attachment: FAB and Awesomebar in opposition.mp4

Comment 9

[Nevin Chen(Not active on Bugzilla)]

Please help prioritize this

Comment 10

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.