1405738 - Enable the JavaScript Start-up Bytecode Cache by default

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P2)

Comment 1

[Nicolas B. Pierron [:nbp]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a98ef3aa627467398089325367efe9964ad5190e

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/929b9943b4fc
Enable the JavaScript Start-up Bytecode Cache. r=mrbkap

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/929b9943b4fc

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

this looks to have improved our tp6 numbers:
https://treeherder.mozilla.org/perf.html#/alerts?id=10314

Comment 5

[Nicolas B. Pierron [:nbp]]

Telemetry alerts[1] are reporting that the JSBC is enabled and working. Latest telemetry data[2] show that 18% of the script tags are loaded from the alternate data cache (i.e. in bytecode format) and 28% are loaded in source format from the network or from the network cache.

The expected result is that it will progressively converge to become ~23% for both column, at least based on the fetch_count results and the current heuristics in place.

[1] http://alerts.telemetry.mozilla.org/index.html#/detectors/1/alerts/?from=2017-11-02&to=2017-11-02&metrics-filter=

[2] https://telemetry.mozilla.org/new-pipeline/dist.html#!cumulative=0&end_date=2017-11-05&keys=__none__!__none__!__none__&max_channel_version=nightly%252F58&measure=DOM_SCRIPT_LOADING_SOURCE&min_channel_version=null&processType=*&product=Firefox&sanitize=1&sort_keys=submissions&start_date=2017-11-04&table=0&trim=1&use_submission_date=0

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Release Note Request (optional, but appreciated)
[Why is this notable]: New important feature
[Affects Firefox for Android]: dunno?
[Suggested wording]: JavaScript Start-up Bytecode Cache introduced
[Links (documentation, blog post, etc)]: Do you have any doc Nicolas?

Comment 7

[mlissner]

It'd be useful to know as a user what this means. Does it affect browser startup? Page load? JS speed?

The Firefox Nightly account is tweeting about this too and lacks context there also:

https://twitter.com/FirefoxNightly/status/927581681661480961

Comment 8

[Nicolas B. Pierron [:nbp]]

(In reply to Sylvestre Ledru [:sylvestre] from comment #6)
> Release Note Request (optional, but appreciated)
> [Why is this notable]:

The detail is in Bug 900784 and its dependent bugs. To make it short:
 1. This removes on average 43 ms of every page load. (while being effective on ~50% of the page loads)
 2. Talos benchmarks reports a 15% improvements on google.com.
 3. On a personal Window computer with PGO, my personal facebook page load improved from 641ms to 522ms.

> [Affects Firefox for Android]:

This should, I have no telemetry data yet to confirm that.

> [Suggested wording]: JavaScript Start-up Bytecode Cache introduced

 * JavaScript: Aims at removing JavaScript parsing time.
 * Start-up: Captures the beginning of the JavaScript execution of *web-pages*, and record only the parser result of functions were used during the load-time of web-pages.
 * Bytecode: Stores the parsed function as byte-code.
 * Cache: Stores the parsed function in the network cache.

> [Links (documentation, blog post, etc)]: Do you have any doc Nicolas?

https://groups.google.com/forum/#!msg/mozilla.dev.platform/4u6EsaDC7kY/1TxDr3-BAgAJ


(In reply to mlissner from comment #7)
> It'd be useful to know as a user what this means. Does it affect browser
> startup? Page load? JS speed?

It does not affect browser start-up.
It improves the average page-load by 43 ms.
It does improves the JS speed, as some functions are parsed sequentially during the page-load.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

> https://groups.google.com/forum/#!msg/mozilla.dev.platform/4u6EsaDC7kY/
> 1TxDr3-BAgAJ

are you planning to write a blog post or some doc?
We cannot link to a thread in a ML from the release notes

Comment 10

[Pascal Chevrel:pascalc (PTO until Sept 2)]

Nicolas, will you or someone from your team provide a short release note description? Since this is not getting backed out, it is probably stable enough to be added to at least 59 Nightly release notes. Thanks

Comment 11

[Nicolas B. Pierron [:nbp]]

Release Note Request (optional, but appreciated)
[Why is this notable]: 5% - 15% page load on some well known websites.
[Affects Firefox for Android]: (supposed to, but no telemetry data to confirm)
[Suggested wording]: Optimize page load by caching JavaScript internal representation.
[Links (documentation, blog post, etc)]: Currently under review by PR, to be published on the JavaScript blog:
https://docs.google.com/a/mozilla.com/document/d/1Sf9YKx52Be0_p0yPmKMDwBEzhwUGTHg-cvAEpVLRKik/edit?usp=sharing

Comment 12

[Nicolas B. Pierron [:nbp]]

(In reply to Nicolas B. Pierron [:nbp] from comment #11)
> [Links (documentation, blog post, etc)]: Currently under review by PR, to be
> published on the JavaScript blog:

Blog post: http://blog.mozilla.org/javascript/2017/12/12/javascript-startup-bytecode-cache/
(it would be published on Tuesday)

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Has been added to the release notes with a link to the blog post!

Merci beaucoup Nicolas!