Closed Bug 1405778 Opened 3 years ago Closed 3 years ago

Remove largely unneeded call to nsDisplayBackgroundColor::GetLayerState

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Assignee: nobody → jmuizelaar
Attachment #8915235 - Flags: review?(bugmail)
Attachment #8915235 - Attachment is obsolete: true
Attachment #8915235 - Flags: review?(bugmail)
Attachment #8915242 - Flags: review?(bugmail)
Comment on attachment 8915242 [details] [diff] [review]
Remove largely unneeded call to nsDisplayBackgroundColor::GetLayerState

Review of attachment 8915242 [details] [diff] [review]:
-----------------------------------------------------------------

Since this patch decouples the background color layer pref from WR, I think it would also make sense to change the gfxPref [1] back to a regular non-override pref, with a default value of "false". Also the pref in all.js [2] can go back to "false".

Alternatively, if we want to keep some meta-pref that enables all the advanced layers in ClientLayerManager, we can just change the dependency function in the gfxPref to point that other meta-pref instead of gfxPrefs::OverrideBase_WebRender().

[1] http://searchfox.org/mozilla-central/rev/e62604a97286f49993eb29c493672c17c7398da9/gfx/thebes/gfxPrefs.h#542
[2] http://searchfox.org/mozilla-central/rev/e62604a97286f49993eb29c493672c17c7398da9/modules/libpref/init/all.js#5888
Attachment #8915242 - Flags: review?(bugmail) → review+
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8fd34c0fa84a
Remove largely unneeded call to nsDisplayBackgroundColor::GetLayerState. r=kats
https://hg.mozilla.org/mozilla-central/rev/8fd34c0fa84a
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.