1405781 - Customize overflow panel scrollbar extends past edge

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[Osmose [:osmose, :mkelly]]

Attachment: Customize Scrollbar Past Edge

In customize mode on MacOS, if the window is short enough that the overflow panel overflows it's content, the scrollbar on the right side sticks out past the edge of the panel. The attached screenshot shows the bug with the patches from bug 1405643 applied to fix other overflow issues, but the scrollbar extends past the edge with or without those patches.

Comment 1

[:Gijs (he/him)]

Hrmpf, this also affects windows 10. Probably need to look at this soon-ish, after all. :-(

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1405781 - don't constrain the width of the overflow panel in customize mode to avoid the scrollbar being placed outside it,

Review commit: https://reviewboard.mozilla.org/r/188032/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/188032/

Comment 3

[:Gijs (he/him)]

Comment on attachment 8916993 [details]
Bug 1405781 - don't constrain the width of the overflow panel in customize mode to avoid the scrollbar being placed outside it,

https://reviewboard.mozilla.org/r/188032/#review193194

::: browser/themes/shared/customizableui/panelUI.inc.css:1741
(Diff revision 1)
>  }
>  
> +/* In customize mode, the overflow list is constrained by its container,
> + * so we set width: auto to avoid the scrollbar not fitting.
> + */
> +#customization-panelHolder .widget-overflow-list {

Self-nit: this should be a child selector

Comment 4

[Mike de Boer [:mikedeboer]]

Comment on attachment 8916993 [details]
Bug 1405781 - don't constrain the width of the overflow panel in customize mode to avoid the scrollbar being placed outside it,

https://reviewboard.mozilla.org/r/188032/#review193198

::: browser/themes/shared/customizableui/panelUI.inc.css:1741
(Diff revision 1)
>  }
>  
> +/* In customize mode, the overflow list is constrained by its container,
> + * so we set width: auto to avoid the scrollbar not fitting.
> + */
> +#customization-panelHolder .widget-overflow-list {

Well, that'd be the only remark I'd have as well. :-D

Comment 5

[:Gijs (he/him)]

Comment on attachment 8916993 [details]
Bug 1405781 - don't constrain the width of the overflow panel in customize mode to avoid the scrollbar being placed outside it,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/188032/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26b13cdf8add
don't constrain the width of the overflow panel in customize mode to avoid the scrollbar being placed outside it, r=mikedeboer

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/26b13cdf8add

Comment 8

[Mike de Boer [:mikedeboer]]

Comment on attachment 8916993 [details]
Bug 1405781 - don't constrain the width of the overflow panel in customize mode to avoid the scrollbar being placed outside it,

Approval Request Comment
[Feature/Bug causing the regression]:
[User impact if declined]: Please see a screenshot of the result in attachment 8915243 [details].
[Is this code covered by automated tests?]: No.
[Has the fix been verified in Nightly?]: No.
[Needs manual test from QE? If yes, steps to reproduce]: Yes. STR:
1. Open Customize Mode (available from the App Menu (aka. Hamburger menu)
2. Drag a number of widgets into the Overflow Menu area, like 5.
3. Resize the browser window small enough to have scrollbars appear on the Overflow Menu area
4. Without this patch the scrollbar should be positioned slightly offset and with the patch it should fit neatly into the area.
[List of other uplifts needed for the feature/fix]: n/a.
[Is the change risky?]: No.
[Why is the change risky/not risky?]: This is a very small graphical CSS change that is constrained to Customize Mode only, not other areas of the browser.
[String changes made/needed]: n/a.

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8916993 [details]
Bug 1405781 - don't constrain the width of the overflow panel in customize mode to avoid the scrollbar being placed outside it,

Photon polish, Beta57+

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b50526883dd5

Comment 11

[Ciprian Georgiu, Desktop QA]

Reproduced this issue using STR from comment 8, on a Nightly build (2017-10-04).

Not reproducible anymore on Win 10 x64, Mac OS X 10.11 and Ubuntu 16.04 x64 with latest Nightly 58.0a1 (20171011220113). I will verify this in 57 Beta 8 as well.

Comment 12

[Ciprian Georgiu, Desktop QA]

Verified fixed on 57 beta 12 as well across platforms: Win 10 x64, Ubuntu 16.04 x64 and macOS 10.13.