Closed
Bug 1405811
Opened 7 years ago
Closed 7 years ago
Convert host compilation flags to moz.build
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox58 fixed)
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: chmanchester, Assigned: chmanchester)
References
Details
Attachments
(2 files)
No description provided.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8923023 [details] Bug 1405811 - Use AC_SUBST_LIST for various variables contributing to host compilation flags. https://reviewboard.mozilla.org/r/194224/#review200090
Attachment #8923023 -
Flags: review?(mshal) → review+
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8923024 [details] Bug 1405811 - Move host compilation flags to mozbuild. https://reviewboard.mozilla.org/r/194226/#review200102 ::: python/mozbuild/mozbuild/frontend/emitter.py:782 (Diff revision 1) > # for the time being. > - if not all(isinstance(l, (RustLibrary, HostRustLibrary)) > - for l in linkables + host_linkables): > + if not all(isinstance(l, (RustLibrary)) for l in linkables): > + self._compile_dirs.add(context.objdir) > + if host_linkables and not all(isinstance(l, HostRustLibrary) for l in host_linkables): > + self._host_compile_dirs.add(context.objdir) > + # TODO: objdirs with only host things in them shouldn't need target Is there a bug on file for this? Or maybe leave a note in bug 1407388 (though that may be specific to the inject Makefile).
Attachment #8923024 -
Flags: review?(mshal) → review+
Assignee | ||
Comment 5•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8923024 [details] Bug 1405811 - Move host compilation flags to mozbuild. https://reviewboard.mozilla.org/r/194226/#review200102 > Is there a bug on file for this? Or maybe leave a note in bug 1407388 (though that may be specific to the inject Makefile). Hm, that bug seems to only cover the inject Makefile. I'll file another.
Pushed by cmanchester@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f34bd383fea0 Use AC_SUBST_LIST for various variables contributing to host compilation flags. r=mshal https://hg.mozilla.org/integration/autoland/rev/08b6c9db493b Move host compilation flags to mozbuild. r=mshal
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f34bd383fea0 https://hg.mozilla.org/mozilla-central/rev/08b6c9db493b
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•