1405840 - mozilla-central has a file whose path is too long to be checked-out on TB's L10N repack builders.

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Tom Prince [:tomprince]]

See https://archive.mozilla.org/pub/thunderbird/nightly/2017/09/2017-09-30-03-02-10-comm-central-l10n/comm-central-win32-l10n-nightly-de-bm94-build1-build8.txt.gz for an example build.

The file
browser/extensions/shield-recipe-client/test/unit/mock_api/api/v1/action/preference-experiment/implementation/sha384-KQgG38GQ7KZAb2VIB48ANQO6nBcxZoLm2ORzUviRT5nAvSywyPjZ5cJIElw6iXIt
is checked out at
c:\builds\moz2_slave\tb-c-cen-w32-l10n-ntly-0000000\build\comm-central\mozilla\
This is exactly 260 characters, which (when the trailing NUL is added) is one longer than the maximum path length on windows.

Comment 1

[Tom Prince [:tomprince]]

This doesn't affect the regular builds, because the repacks add an additional directory level containing the branch-name (https://dxr.mozilla.org/build-central/source/buildbotcustom/process/factory.py#2694) which pushes the path length over the limit for comm-central and comm-release.

Comment 2

[Tom Prince [:tomprince]]

Attachment: Bug 1405840: Use a shorter path name for L10N repacks on post-esr52 branches.

Review commit: https://reviewboard.mozilla.org/r/186946/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/186946/

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8915741 [details]
Bug 1405840: Use a shorter path name for L10N repacks on post-esr52 branches.

https://reviewboard.mozilla.org/r/186946/#review192174

Confirmed this only affects 'Thunderbird comm-central * l10n nightly'. r+

Comment 4

[Tom Prince [:tomprince]]

https://hg.mozilla.org/build/buildbotcustom/rev/58ae39c58ef73bafca7d915d36fcf40f72f551f1
https://hg.mozilla.org/build/buildbotcustom/rev/e652aeb5fe91ce369686185093c7344bac51315b

Comment 5

[Tom Prince [:tomprince]]

https://dxr.mozilla.org/build-central/source/buildbotcustom/process/factory.py#3185 also needs to be adjusted.

Comment 6

[Tom Prince [:tomprince]]

Attachment: Bug 1405840: Use shorter pathname for TOOLTOOL_DIR too in L10N repacks.

Review commit: https://reviewboard.mozilla.org/r/187522/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187522/

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8916314 [details]
Bug 1405840: Use shorter pathname for TOOLTOOL_DIR too in L10N repacks.

https://reviewboard.mozilla.org/r/187522/#review194270

Comment 8

[Tom Prince [:tomprince]]

https://hg.mozilla.org/build/buildbotcustom/rev/5f1038a8cca94009c77ee7377a353709f7c7bb30

Comment 9

[Tom Prince [:tomprince]]

Attachment: Bug 1405840: Don't reset TOOLTOOL_DIR in NightlyRepackFactory.

This was oringaly added in 77f2f273a89a (Bug 1234220) but later in 01f02115479b
(Bug 1306192) the variable was set in the factory environment. Get rid of the
former now, so that changes don't need to be coordinated.

Review commit: https://reviewboard.mozilla.org/r/190200/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/190200/

Comment 10

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8919342 [details]
Bug 1405840: Don't reset TOOLTOOL_DIR in NightlyRepackFactory.

https://reviewboard.mozilla.org/r/190200/#review196108

Comment 11

[Nick Thomas [:nthomas] (UTC+12)]

https://hg.mozilla.org/build/buildbotcustom/rev/190f312f57a27181a18277bf20b726fd3c1bdccb
https://hg.mozilla.org/build/buildbotcustom/rev/23352e99144b9e5fa5016274202d5fe01244f9b6