Closed Bug 1405908 Opened 2 years ago Closed 2 years ago

Restyle prefapi.cpp

Categories

(Core :: Preferences: Backend, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: njn, Assigned: njn)

References

Details

Attachments

(2 files)

Process:

- Patch 1: Run clang-format to fix whitespace.

- Patch 2: Do manual fix-ups -- braces, rename things, etc. -- and then finish with another clang-format.
Comment on attachment 8915429 [details]
Bug 1405908 - Restyle prefapi.cpp (clang-format). .

https://reviewboard.mozilla.org/r/186620/#review191742
Attachment #8915429 - Flags: review?(mh+mozilla) → review+
Comment on attachment 8915430 [details]
Bug 1405908 - Restyle prefapi.cpp (manual + clang-format). .

https://reviewboard.mozilla.org/r/186622/#review191746

Possible followups:
- Stop using NS_str*
- Stop using PL_str*
- Use operator new instead of malloc.

::: modules/libpref/prefapi.cpp:513
(Diff revision 1)
> +
>    return rv;
>  }
>  
>  nsresult
> -PREF_GetIntPref(const char* pref_name, int32_t* return_int, bool get_default)
> +PREF_GetIntPref(const char* aPrefName, int32_t* aIntOut, bool aGetDefault)

aIntOut got me confused, I read it as aInOut first. aValueOut would be less confusing.
Attachment #8915430 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/f5d49a80eed8
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Assignee: nobody → n.nethercote
You need to log in before you can comment on or make changes to this bug.