(photon) Color and dimension adjustment for URL bar and status bar

VERIFIED FIXED in Firefox 57

Status

()

defect
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: jwu, Assigned: jwu)

Tracking

(Blocks 2 bugs)

Trunk
Firefox 58
Unspecified
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed, firefox58 fixed)

Details

(Whiteboard: [FNC][SPT58.2][INT])

Attachments

(4 attachments)

Designer has given us some feedback with current Nightly build, some minor adjustments are need to improve the visual design.

1. Increase the progress bar height from 2dp to 3dp
2. Change the status bar background color to #F9F9FA.
3. Change the URL placeholder colors to #B2B2B2/#737373 on normal/private mode respectively.
Comment on attachment 8915476 [details]
Bug 1405954 - Part 3: Change placeholder colors on URL bar.

https://reviewboard.mozilla.org/r/186676/#review191814
Attachment #8915476 - Flags: review?(cnevinchen) → review+
Comment on attachment 8915475 [details]
Bug 1405954 - Part 2: Change status bar background color to #F9F9FA.

https://reviewboard.mozilla.org/r/186674/#review191816
Attachment #8915475 - Flags: review?(cnevinchen) → review+
Comment on attachment 8915474 [details]
Bug 1405954 - Part 1: Increase progress bar height from 2dp to 3dp.

https://reviewboard.mozilla.org/r/186672/#review191818
Attachment #8915474 - Flags: review?(cnevinchen) → review+
Pushed by topwu.tw@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/465519a6bae7
Part 1: Increase progress bar height from 2dp to 3dp. r=nechen
https://hg.mozilla.org/integration/autoland/rev/85adac773f9a
Part 2: Change status bar background color to #F9F9FA. r=nechen
https://hg.mozilla.org/integration/autoland/rev/92eef0c075fe
Part 3: Change placeholder colors on URL bar. r=nechen
Comment on attachment 8915474 [details]
Bug 1405954 - Part 1: Increase progress bar height from 2dp to 3dp.

Approval Request Comment
[Feature/Bug causing the regression]:
Adjust color and dimension for URL bar and status bar.

[User impact if declined]:
The color and dimension on URL bar/status bar might not meet designer's request. This is a Photon related UI bug.

[Is this code covered by automated tests?]:
No

[Has the fix been verified in Nightly?]:
Not yet.

[Needs manual test from QE? If yes, steps to reproduce]: 
Yes, check the color and dimension are adjusted as mentioned in bug 1405954 comment 0.

[List of other uplifts needed for the feature/fix]:
There are another two patches:
attachment 8915475 [details]
attachment 8915476 [details]

[Is the change risky?]:
No

[Why is the change risky/not risky?]:
This patch only adjust UI layout.

[String changes made/needed]:
No
Attachment #8915474 - Flags: approval-mozilla-beta?
Comment on attachment 8915474 [details]
Bug 1405954 - Part 1: Increase progress bar height from 2dp to 3dp.

Photon polish, Beta57+
Attachment #8915474 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Whiteboard: [FNC][SPT58.2][INT]
Verified as fixed on both Nightly (58.0a1 - 2017-10-19)and latest Beta 57.0b9 on Pixel (Android 8.0)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.