1406029 - SnoozeTabs Buttons and time selector partly hidden when in overflow menu

Status: RESOLVED DUPLICATE of bug 1403466

(Firefox :: Toolbars and Customization, defect)

Description

[Albert Scheiner [:alberts]]

Attachment: ff-snoozetab_controls-partly-hidden.png

- move Snooze Tab to overflow menu
- click "Snooze tab until ...."
- click "Choose a Date/Time" (even in this view the button at the bottom doens't show)
- try to choose a time

Comment 1

[:Gijs (he/him)]

I assume this is the test pilot add-on? If not, please provide installation instructions.

I can't reproduce the grey bar at the bottom. The add-on seems to have its own footer, but that displays without issues. I can see that the overflow menu doesn't vertically resize on OS X, which is an issue... Either way, the symptoms here are the same as in bug 1403466, it seems?

Comment 2

[Albert Scheiner [:alberts]]

(In reply to :Gijs (no reviews, PTO EOB on 11th) from comment #1)
> I assume this is the test pilot add-on? If not, please provide installation
> instructions.

Yeah, that's the one. I added related links to "See Also" including one I raised over at GitHub.

> I can't reproduce the grey bar at the bottom. The add-on seems to have its
> own footer, but that displays without issues. I can see that the overflow
> menu doesn't vertically resize on OS X, which is an issue... Either way, the
> symptoms here are the same as in bug 1403466, it seems?

- I installed the try build from bug 1406031#c4
- fresh install of https://testpilot.firefox.com/experiments/snooze-tabs
- move Snooze Tabs' icon by using "Pin to Overflow Menu"
- click Snooze Tabs' icon

I'll upload a video in a sec showing the issue on macOS 10.11

Comment 3

[Albert Scheiner [:alberts]]

Attachment: 1406029-overflow-panel-bottom-cut-off.ogv

Comment 4

[Albert Scheiner [:alberts]]

Attachment: video-mime-type-error.png

BTW, I get a MIME-type error message within the video when I play it. Not sure what that is about, but the video plays, so that should hopefully not be a problem, otherwise let me know and I convert it again.

Comment 5

[Albert Scheiner [:alberts]]

I installed the try build from bug 1406031#c6 and it works fine!

My comment from over there that is actually more related to this task:

Gijs, can you do me one favour and test one more thing in case it worth a new bug:
- click "Snooze Tab until ..." icon in overflow panel
- select "Pick a Date/Time"
- select the next day from the calendar
- click on the time picker
- try to scroll to 21:58
-> this seems to me still cropped off, but more due to the stacking context; should the time picker maybe open up to the top instead of the bottom?

Comment 6

[:Gijs (he/him)]

(In reply to Albert Scheiner [:alberts] from comment #5)
> I installed the try build from bug 1406031#c6 and it works fine!
> 
> My comment from over there that is actually more related to this task:
> 
> Gijs, can you do me one favour and test one more thing in case it worth a
> new bug:
> - click "Snooze Tab until ..." icon in overflow panel
> - select "Pick a Date/Time"
> - select the next day from the calendar
> - click on the time picker
> - try to scroll to 21:58
> -> this seems to me still cropped off, but more due to the stacking context;
> should the time picker maybe open up to the top instead of the bottom?

Maybe Blake knows the answer to how this works and/or should work, and if we need either a separate github issue or a separate bug on the Core::DOM stuff that manages our <input type=date> implementation, or something.

Comment 7

[Blake Winton (:bwinton) (:☕️)]

That sounds more to me like a bug in SnoozeTabs (which is using an off-the-shelf react calendar component). Albert, did you want to look through https://github.com/bwinton/SnoozeTabs/issues/ and see if it's reported there (and if not, file a new issue)?

Thanks!

Comment 8

[Blake Winton (:bwinton) (:☕️)]

(Actually, I just noticed you did that, so nevermind. :D )

Comment 9

[Albert Scheiner [:alberts]]

Closed https://github.com/bwinton/SnoozeTabs/issues/362 and opened a new bug https://github.com/bwinton/SnoozeTabs/issues/364 as it is not related to the overflow panel, but maybe a more general issue.