1406047 - Push a composite if needed in EndEmptyTransaction

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P1)

Description

[Kartikaya Gupta (email:[e-mail])]

EndEmptyTransaction takes EndTransactionFlags, and if those flags don't contain END_NO_COMPOSITE, we should request a composite. This is important because it can trigger a DidComposite call which things might be waiting for.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7fae83c8f1c2075d1e99bfeb014c09eb84a49cf3

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1406047 - Schedule a composite in empty transactions that require it.

Review commit: https://reviewboard.mozilla.org/r/186812/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/186812/

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8915623 [details]
Bug 1406047 - Schedule a composite in empty transactions that require it.

https://reviewboard.mozilla.org/r/186812/#review191920

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b60f5875a26
Schedule a composite in empty transactions that require it. r=jrmuizel

Comment 5

[Sotaro Ikeda [:sotaro]]

attachment 8915623 [details] seems not trigger the DidComposite for the EndEmptyTransaction. WebRenderLayerManager::ScheduleComposite() just triggers re-composite.

WebRenderLayerManager needs to send TransactionId to WebRenderBridgeParent. The Id could be got by "mTransactionIdAllocator->GetTransactionId(/*aThrottle*/ true);".

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3b60f5875a26