Closed
Bug 1406051
Opened 7 years ago
Closed 7 years ago
Double context menu separator on image link when selecting text
Categories
(Firefox :: Menus, defect, P4)
Tracking
()
VERIFIED
FIXED
Firefox 58
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox56 | --- | wontfix |
firefox57 | --- | wontfix |
firefox58 | --- | verified |
People
(Reporter: kanatay01, Assigned: eoger)
References
()
Details
(Keywords: regression)
Attachments
(2 files)
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20171005100211
Steps to reproduce:
1. Select text.
2. Open the context menu by clicking on image link (e.g. on <a href=""><img src=""></a>).
Updated•7 years ago
|
Blocks: 1359894
Status: UNCONFIRMED → NEW
status-firefox56:
--- → affected
status-firefox57:
--- → affected
status-firefox58:
--- → affected
status-firefox-esr52:
--- → unaffected
Ever confirmed: true
Flags: needinfo?(eoger)
Keywords: regression
Priority: -- → P4
Updated•7 years ago
|
Comment 1•7 years ago
|
||
Fairly minor regression, doesn't affect functionality, marking wontfix for 56.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → eoger
Flags: needinfo?(eoger)
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8917142 [details]
Bug 1406051 - Don't show two separators in context menu.
https://reviewboard.mozilla.org/r/188150/#review194176
We should have a test for this. You should be able to add to browser/base/content/test/general/browser_contextmenu.js
::: browser/base/content/browser-sync.js:469
(Diff revision 1)
> contextMenu.onImage || contextMenu.onCanvas ||
> contextMenu.onVideo || contextMenu.onAudio ||
> contextMenu.onLink || contextMenu.onTextInput);
>
> - ["context-sendpagetodevice", "context-sep-sendpagetodevice"]
> + // Avoids double separator on images with links.
> + const hideSeparator = contextMenu.isContentSelected && contextMenu.onLink && contextMenu.onImage;
Can you break this up into multiple lines?
Attachment #8917142 -
Flags: review?(jaws) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 5•7 years ago
|
||
I don't have a strong opinion if we should uplift this to 57, it's a fairly minor visual regression. What do you think Liz?
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4730ce3175f8
Don't show two separators in context menu. r=jaws
![]() |
||
Comment 7•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Comment 8•7 years ago
|
||
Given where we are in the cycle, I think this should probably ride the 58 train, but feel free to set the 57 status back to affected and request Beta approval if you feel strongly otherwise.
Comment 9•7 years ago
|
||
I have reproduced this bug with Nightly 58.0a1 (2017-10-08) on Ubuntu 16.04, 64 bit!
The fix is now verified on Latest Nightly 58.0a1.
Build ID 20171022100058
User Agent Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0
QA Whiteboard: [bugday-20171018]
Comment 10•7 years ago
|
||
Thanks for the verification. Updating the tracking flags and bug status.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•