Closed Bug 1406061 Opened 2 years ago Closed 2 years ago

remove devtools/client/shared/Jsbeautify.jsm

Categories

(DevTools :: Framework, enhancement, P3)

enhancement

Tracking

(firefox57 fix-optional, firefox58 fixed)

RESOLVED FIXED
Firefox 58
Tracking Status
firefox57 --- fix-optional
firefox58 --- fixed

People

(Reporter: tromey, Assigned: pbro)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

devtools/client/shared/Jsbeautify.jsm seems to be a lingering shim,
not used from devtools any more.  I think it can be removed.
The css part of jsbeautify doesn't seem to be used.
And, since we have pretty-fast, maybe all of jsbeautify could be removed.
Priority: -- → P3
Comment on attachment 8920045 [details]
Bug 1406061 - Remove the unused Jsbeautify.jsm module;

https://reviewboard.mozilla.org/r/191036/#review196250

LGTM, but I think this should be deleted too:
http://searchfox.org/mozilla-central/rev/d0448c970093f94bd986a21d3a9e8c366b316eb4/tools/lint/eslint/modules.json#113
Attachment #8920045 - Flags: review?(jdescottes) → review+
Pushed by pbrosset@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fc6cfc87908b
Remove the unused Jsbeautify.jsm module; r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/fc6cfc87908b
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.