Closed
Bug 1406061
Opened 7 years ago
Closed 7 years ago
remove devtools/client/shared/Jsbeautify.jsm
Categories
(DevTools :: Framework, enhancement, P3)
DevTools
Framework
Tracking
(firefox57 fix-optional, firefox58 fixed)
RESOLVED
FIXED
Firefox 58
Tracking | Status | |
---|---|---|
firefox57 | --- | fix-optional |
firefox58 | --- | fixed |
People
(Reporter: tromey, Assigned: pbro)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
devtools/client/shared/Jsbeautify.jsm seems to be a lingering shim, not used from devtools any more. I think it can be removed.
Reporter | ||
Comment 1•7 years ago
|
||
The css part of jsbeautify doesn't seem to be used. And, since we have pretty-fast, maybe all of jsbeautify could be removed.
Assignee | ||
Updated•7 years ago
|
status-firefox57:
--- → fix-optional
Priority: -- → P3
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7601a2c6f9e2a5934bcf748d1ecec4a04cfbb887&group_state=expanded
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8920045 [details] Bug 1406061 - Remove the unused Jsbeautify.jsm module; https://reviewboard.mozilla.org/r/191036/#review196250 LGTM, but I think this should be deleted too: http://searchfox.org/mozilla-central/rev/d0448c970093f94bd986a21d3a9e8c366b316eb4/tools/lint/eslint/modules.json#113
Attachment #8920045 -
Flags: review?(jdescottes) → review+
Comment hidden (mozreview-request) |
Pushed by pbrosset@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fc6cfc87908b Remove the unused Jsbeautify.jsm module; r=jdescottes
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/fc6cfc87908b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•