Closed
Bug 1406069
Opened 7 years ago
Closed 7 years ago
Migrate browser_cached_messages.js to the new frontend
Categories
(DevTools :: Console, enhancement, P3)
DevTools
Console
Tracking
(firefox58 fixed)
RESOLVED
FIXED
Firefox 58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
Details
Attachments
(1 file)
No description provided.
|
||
Updated•7 years ago
|
Priority: -- → P3
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8925444 [details] Bug 1406069 - Enable browser_webconsole_cached_messages.js in new console frontend; . https://reviewboard.mozilla.org/r/196574/#review201794 Looks good Nicolas, thanks! ::: devtools/client/webconsole/new-console-output/test/mochitest/head.js:358 (Diff revision 1) > +/** > + * Open the Web Console for the given tab, or the current one if none given. > + * > + * @param nsIDOMElement tab > + * Optional tab element for which you want open the Web Console. The > + * default tab is taken from the global variable |tab|. the comment looks incorrect, the default tab is taken from the browser's selected tab, not from a tab global.
Attachment #8925444 -
Flags: review?(jdescottes) → review+
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 4•7 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8925444 [details] Bug 1406069 - Enable browser_webconsole_cached_messages.js in new console frontend; . https://reviewboard.mozilla.org/r/196574/#review201794 > the comment looks incorrect, the default tab is taken from the browser's selected tab, not from a tab global. Good catch, thanks for the review
| Comment hidden (mozreview-request) |
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/deaf42e9dbec Enable browser_webconsole_cached_messages.js in new console frontend; r=jdescottes.
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/deaf42e9dbec
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•