1406097 - Don't manually remember the attribution code

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P1)

Description

[Alessio Placitelli [:Dexter]]

In bug 1400870 we landed a fix to make the attribution code available after the first subsession. We should improve that fix as shown below.

(In reply to Georg Fritzsche [:gfritzsche] [away Sep 19 - Oct 3] from comment #25)
> Alessio, Matt, one question about the fix here:
> Can we, in a follow-up bug, improve this for the TelemetryEnvironment to not
> manually remember the attribution code?
> It seems that with the caching in AttributionCode.jsm, TelemetryEnvironment
> should be able to just always use AttributionCode.getCachedAttributionCode()
> or so?

Comment 1

[Alessio Placitelli [:Dexter]]

Attachment: Bug 1406097 - Use the cached attribution code in the environment.

This adds a new sync function to AttributionCode.jsm that returns the cached
attribution data. The cached data is then used to populate the environment
instead of relying on the async function.

Review commit: https://reviewboard.mozilla.org/r/187694/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187694/

Comment 2

[Georg Fritzsche [:gfritzsche]]

I think Matt knows better about the AttributionCode.
Let me know if i can help clear up any specific questions.

Comment 3

[Molly Howell (she/her) (no longer active)]

Comment on attachment 8916549 [details]
Bug 1406097 - Use the cached attribution code in the environment.

https://reviewboard.mozilla.org/r/187694/#review192782

Looks good to me. Thanks!

Comment 4

[Alessio Placitelli [:Dexter]]

Comment on attachment 8916549 [details]
Bug 1406097 - Use the cached attribution code in the environment.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/187694/diff/1-2/

Comment 5

[Alessio Placitelli [:Dexter]]

Comment on attachment 8916549 [details]
Bug 1406097 - Use the cached attribution code in the environment.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/187694/diff/2-3/

Comment 6

[Alessio Placitelli [:Dexter]]

Comment on attachment 8916549 [details]
Bug 1406097 - Use the cached attribution code in the environment.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/187694/diff/3-4/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ad20a772a81
Use the cached attribution code in the environment. r=mhowell

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5ad20a772a81