Closed Bug 1406097 Opened 3 years ago Closed 3 years ago

Don't manually remember the attribution code

Categories

(Toolkit :: Telemetry, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: Dexter, Assigned: Dexter)

References

Details

Attachments

(1 file)

In bug 1400870 we landed a fix to make the attribution code available after the first subsession. We should improve that fix as shown below.

(In reply to Georg Fritzsche [:gfritzsche] [away Sep 19 - Oct 3] from comment #25)
> Alessio, Matt, one question about the fix here:
> Can we, in a follow-up bug, improve this for the TelemetryEnvironment to not
> manually remember the attribution code?
> It seems that with the caching in AttributionCode.jsm, TelemetryEnvironment
> should be able to just always use AttributionCode.getCachedAttributionCode()
> or so?
Blocks: 1400870
Priority: -- → P1
Assignee: nobody → alessio.placitelli
Attachment #8916549 - Flags: review?(gfritzsche) → review?(mhowell)
I think Matt knows better about the AttributionCode.
Let me know if i can help clear up any specific questions.
Comment on attachment 8916549 [details]
Bug 1406097 - Use the cached attribution code in the environment.

https://reviewboard.mozilla.org/r/187694/#review192782

Looks good to me. Thanks!
Attachment #8916549 - Flags: review?(mhowell) → review+
Pushed by alessio.placitelli@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/5ad20a772a81
Use the cached attribution code in the environment. r=mhowell
https://hg.mozilla.org/mozilla-central/rev/5ad20a772a81
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.