Closed
Bug 1406150
Opened 7 years ago
Closed 7 years ago
TypeError: class constructors must be invoked with |new| in driver.js
Categories
(Remote Protocol :: Marionette, defect)
Tracking
(firefox-esr52 unaffected, firefox56 wontfix, firefox57 fixed, firefox58 fixed)
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox-esr52 | --- | unaffected |
| firefox56 | --- | wontfix |
| firefox57 | --- | fixed |
| firefox58 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
(Keywords: regression)
Attachments
(1 file)
As filed as https://github.com/mozilla/geckodriver/issues/995 there are a couple of places in driver.js which do not raise exceptions the right way. All of them miss `new`. One case is covered by bug 1405325 already, but all the others not. CurrentUrl: http://searchfox.org/mozilla-central/source/testing/marionette/driver.js#207 title: http://searchfox.org/mozilla-central/source/testing/marionette/driver.js#223 installAddon: http://searchfox.org/mozilla-central/source/testing/marionette/driver.js#3323 This is a regression as introduced by different bugs in the past. It means we cannot fix it for Firefox 56 because it has already been released, but we can do for both 57.0 and 58.0.
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8915953 [details] Bug 1406150 - Always throw exceptions by using 'new'. https://reviewboard.mozilla.org/r/187230/#review192274 I found a few more of these in navigation.js and packets.js -- could you fix those too, please?
Attachment #8915953 -
Flags: review?(mjzffr)
| Comment hidden (mozreview-request) |
|
|
||
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8915953 [details] Bug 1406150 - Always throw exceptions by using 'new'. https://reviewboard.mozilla.org/r/187230/#review192276
Attachment #8915953 -
Flags: review?(mjzffr) → review+
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3d7f66f234ad Always throw exceptions by using 'new'. r=maja_zf
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3d7f66f234ad
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
|
||
Updated•7 years ago
|
status-firefox-esr52:
--- → unaffected
|
|
||
Comment 7•7 years ago
|
||
| bugherder uplift | ||
https://hg.mozilla.org/releases/mozilla-beta/rev/9802ea8f6220
|
||
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•