Closed Bug 1406166 Opened 3 years ago Closed 3 years ago

Make reftest.jsm's OnRefTestLoad function a global function

Categories

(Testing :: Reftest, enhancement)

enhancement
Not set

Tracking

(firefox58 fixed)

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

Details

Attachments

(1 file)

reftest.jsm's exported OnRefTestLoad symbol is currently assigned to this.OnRefTestLoad whereas the exported symbol OnRefTestFinished is simply a global function. It seems OnRefTestLoad could also be a global function, and that has the advantage that it then appears in the outline view of my editor along with everything else, rather than being hidden from the outline view as it is now.
Attached patch patchSplinter Review
Attachment #8915758 - Flags: review?(dholbert)
searchfox says this was added in bug 798491 (as part of 2 changes to that file, which was called reftest.js at that point):
https://hg.mozilla.org/mozilla-central/diff/5ce71981e005/layout/tools/reftest/reftest.js

Apparently the change was to reduce the number of compartments on B2G, for performance reasons I think (and specifically perf of B2G reftest runs, in the case of this file, I assume).

Given that, and specifically bug 798491 comment 108 ("can we undo this ugliness"), it sounds like it's fine to revert this.
Attachment #8915758 - Flags: review?(dholbert) → review+
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd91c0f96f17
Make reftest.jsm's OnRefTestLoad function a global function. r=dholbert
https://hg.mozilla.org/mozilla-central/rev/fd91c0f96f17
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.