Closed Bug 1406168 Opened 2 years ago Closed 2 years ago

Remove JNI.jsm

Categories

(Firefox for Android :: General, enhancement, P3)

All
Android
enhancement

Tracking

()

RESOLVED FIXED
Firefox 58
Tracking Status
fennec + ---
firefox56 --- wontfix
firefox57 --- wontfix
firefox58 --- fixed

People

(Reporter: jchen, Assigned: jchen)

Details

Attachments

(5 files)

JNI.jsm was a way for addons (and some internal code) to access Java from JS. However, its API exposes raw JNI calls to the user, and it's very hard to use it correctly when it comes to keeping references, etc.

It's no longer relevant with WebExtension-only addons, and the few places in Fennec code that use JNI.jsm should be made to use other techniques such as EventDispatcher. Afterwards, we should be able to remove JNI.jsm altogether.
tracking-fennec: --- → ?
OS: Unspecified → Android
Hardware: Unspecified → All
Assignee: nobody → nchen
tracking-fennec: ? → +
Priority: -- → P3
Comment on attachment 8923867 [details]
Bug 1406168 - 1. Remove JNI.jsm;

https://reviewboard.mozilla.org/r/195022/#review200066

::: mobile/android/components/DirectoryProvider.js:180
(Diff revision 1)
>          return result.shift();
>        }
>      };
>    },
>  
>    _getDistributionDirectories: function() {

Ah, this was the only time I used JNI.jsm myself. :)
Attachment #8923867 - Flags: review?(s.kaspari) → review+
Comment on attachment 8923868 [details]
Bug 1406168 - 2. Remove AndroidJNIWrapper;

https://reviewboard.mozilla.org/r/195024/#review200532
Attachment #8923868 - Flags: review?(snorp) → review+
Comment on attachment 8923869 [details]
Bug 1406168 - 3. Remove AndroidJavaWrappers;

https://reviewboard.mozilla.org/r/195026/#review200534
Attachment #8923869 - Flags: review?(snorp) → review+
You need to log in before you can comment on or make changes to this bug.