Closed
Bug 1406193
Opened 7 years ago
Closed 7 years ago
Remove last remaining SocialAPI bits
Categories
(Firefox Graveyard :: SocialAPI, enhancement)
Tracking
(firefox57 wontfix, firefox58 fixed)
RESOLVED
FIXED
Firefox 58
People
(Reporter: mixedpuppy, Assigned: thegalaxiasgroup, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [tor 13612])
Attachments
(1 file, 4 obsolete files)
2.73 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
Some social.* prefs were missed during removal.
Comment 1•7 years ago
|
||
Affected files: http://searchfox.org/mozilla-central/search?q=%5Cbsocial%5C.&case=true®exp=true&path=
Mentor: dao+bmo
Keywords: good-first-bug
Summary: remove lingering prefs → Remove last remaining SocialAPI bits
Assignee | ||
Comment 2•7 years ago
|
||
If the only task is to simply delete this lines i'm on it and going to put a patch on review soon.
Assignee | ||
Comment 3•7 years ago
|
||
Assignee | ||
Comment 4•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Attachment #8916422 -
Attachment is obsolete: true
Comment 5•7 years ago
|
||
Comment on attachment 8916423 [details] [diff] [review] Remove last remaining SocialAPI bits () >- // Messages sent from browser-social.js >- "Social:", >- "PageMetadata:", We'll still need "PageMetadata:". Looks good otherwise!
Updated•7 years ago
|
Assignee: nobody → thegalaxiasgroup
Assignee | ||
Comment 6•7 years ago
|
||
Comment 8•7 years ago
|
||
(In reply to Simon Van Accoleyen from comment #7) > Is it okay like this? Your new patch seems to be based on the first one. Instead, we'll need one unified patch.
Assignee | ||
Comment 9•7 years ago
|
||
Attachment #8916423 -
Attachment is obsolete: true
Attachment #8916714 -
Attachment is obsolete: true
Assignee | ||
Comment 10•7 years ago
|
||
Now i hope everything is ok! Sorry to be so long, this is my first ever bug (and i still don't know how to use mercurial correctly...)
Comment 11•7 years ago
|
||
Comment on attachment 8917020 [details] [diff] [review] Third attempt to correctly remove all last bits of SocialAPI This is just one patch file appended to the other. We'll need these changes in a single patch produced by mercurial. (In reply to Simon Van Accoleyen from comment #10) > Now i hope everything is ok! Sorry to be so long, this is my first ever bug > (and i still don't know how to use mercurial correctly...) No problem, take the time you need.
Updated•7 years ago
|
status-firefox57:
--- → wontfix
Assignee | ||
Comment 12•7 years ago
|
||
(In reply to Dão Gottwald [::dao] from comment #11) > This is just one patch file appended to the other. > We'll need these changes in a single patch produced by mercurial. What's wrong with this patch? It's a single file for all the changes, and it was made by mercurial...
Status: ASSIGNED → NEW
Comment 13•7 years ago
|
||
(In reply to Simon Van Accoleyen from comment #12) > (In reply to Dão Gottwald [::dao] from comment #11) > > > This is just one patch file appended to the other. > > We'll need these changes in a single patch produced by mercurial. > > > What's wrong with this patch? It's a single file for all the changes, and it > was made by mercurial... It contains two patch headers; look for "# HG changeset patch"...
Assignee | ||
Comment 14•7 years ago
|
||
I hope that this will be fine! Thanks for the help guys.
Attachment #8917020 -
Attachment is obsolete: true
Flags: needinfo?(dao+bmo)
Comment 15•7 years ago
|
||
Comment on attachment 8920809 [details] [diff] [review] Latest Patch Looks good. Thanks!
Flags: needinfo?(dao+bmo)
Attachment #8920809 -
Flags: review+
Comment 16•7 years ago
|
||
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/125a67a1750f Remove last remaining SocialAPI bits. r=dao
Assignee | ||
Updated•7 years ago
|
Status: NEW → ASSIGNED
Comment 17•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/125a67a1750f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Updated•6 years ago
|
Whiteboard: [tor 13612]
Updated•5 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•