Closed Bug 1406224 Opened 2 years ago Closed 2 years ago

Remove nsIDOMHTMLImageElement

Categories

(Core :: DOM: Core & HTML, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: qdot, Assigned: qdot)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Continuing post-addon-deprecation XPCOM interface cleanup
Priority: -- → P3
Comment on attachment 8916125 [details]
Bug 1406224 - Remove nsIDOMHTMLImageElement;

https://reviewboard.mozilla.org/r/187352/#review194534

r=me modulo the changes to the NaturalWidth/Height methods on HTMLImageElement

::: dom/html/HTMLImageElement.h:88
(Diff revision 2)
>  
>    nsresult CopyInnerTo(Element* aDest, bool aPreallocateChildren);
>  
>    void MaybeLoadImage(bool aAlwaysForceLoad);
>  
> +  // Overrides for nsImageLoadingContent's GetNaturalHeight/Width, since we

Why did this get moved from where it used to live?

Also, why the switch from NS_IMETHOD to nsresult?  That doesn't seem right.  In general, I'm not sure why these methods got touched at all.
Attachment #8916125 - Flags: review?(bzbarsky) → review+
Comment on attachment 8916125 [details]
Bug 1406224 - Remove nsIDOMHTMLImageElement;

https://reviewboard.mozilla.org/r/187352/#review194536

Oh, and please file a bug on editor/ui/composer/content/editor.js changing to getClassName.
Comment on attachment 8916125 [details]
Bug 1406224 - Remove nsIDOMHTMLImageElement;

https://reviewboard.mozilla.org/r/187352/#review194536

I meant in the comm-central tree...
Comment on attachment 8916125 [details]
Bug 1406224 - Remove nsIDOMHTMLImageElement;

https://reviewboard.mozilla.org/r/187352/#review194536

And actually, there are some uses in suite/ that will need to be fixed in comm-central too, in C++.
Comment on attachment 8916125 [details]
Bug 1406224 - Remove nsIDOMHTMLImageElement;

https://reviewboard.mozilla.org/r/187352/#review194534

> Why did this get moved from where it used to live?
> 
> Also, why the switch from NS_IMETHOD to nsresult?  That doesn't seem right.  In general, I'm not sure why these methods got touched at all.

I was chopping through XPCOM accessors a little /too/ carelessly and didn't realize those were overrides for nsImageLoadingContent. Replaced them instead of just killing that change, which is why they moved. Restoring everything to where it was originally now.
comm-central bug was filed when I created this bug, bug 1406227
https://hg.mozilla.org/mozilla-central/rev/17fbd19e4360
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.