1406233 - Fix #include directives for device number macros in bug 1401666

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect, P1)

Description

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

See bug 1401666 comment #31 through 35, and see also bug 1329798 which is the same problem in a different part of the code: we need to #include <sys/sysmacros.h> to get the macros that split device numbers into major/minor.  Apparently this used to be pulled in by <sys/types.h> but newer glibcs no longer do that, so the build is currently broken on those systems.

Comment 1

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: Bug 1406233 - Include sys/sysmacros.h for major()/minor() macros in Linux sandbox broker.

Review commit: https://reviewboard.mozilla.org/r/187008/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187008/

Comment 2

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 8915787 [details]
Bug 1406233 - Include sys/sysmacros.h for major()/minor() macros in Linux sandbox broker.

https://reviewboard.mozilla.org/r/187008/#review192352

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9fc84ba52f31
Include sys/sysmacros.h for major()/minor() macros in Linux sandbox broker. r=gcp

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/9fc84ba52f31

Comment 5

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8915787 [details]
Bug 1406233 - Include sys/sysmacros.h for major()/minor() macros in Linux sandbox broker.

This is needed for uplifting the fix for bug 1401666 to 57.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a6373996bfa6