1406243 - Scrolling in Monaco Editor also scrolls the document

Status: RESOLVED FIXED

(Core :: DOM: Events, defect, P3)

Description

[manasgarg]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20170928180207

Steps to reproduce:

Go to https://microsoft.github.io/monaco-editor/. Take the mouse on editor window. Scroll up and down using the touchpad of a macbook.


Actual results:

The editor as well as document scroll up/down.


Expected results:

Only the editor content should scroll up/down.

Comment 1

[Jet Villegas (inactive)]

Masayuki: can you trace how we propagate scroll events in this case? It seems like we mostly keep scroll handling on the focused element (e.g., when cmd-scroll) but regular scroll still targets the viewport. Thx!

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

Hmm, I cannot reproduce this bug on Windows. Although, I'll check it on macOS later.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

Resetting assignee which I don't work on in this several months.

Comment 4

[Adam Stevenson [:adamopenweb]]

I'm unable to reproduce this issue in Firefox 80 & 82 on MacOS. Using a Macbook Pro with touchpad. Scrolling in the editor window only scrolls the editor, not the full document.

Marking as Fixed, could someone confirm this is fixed please?

Comment 5

[Karl Dubost💡 :karlcow]

Confirmed.