Closed Bug 1406272 Opened 7 years ago Closed 7 years ago

TalosError("timeout") on running startup_test/tresize/addon/content/tresize-test.html

Categories

(Core :: Graphics: WebRender, defect, P1)

Product:
Core
Component:
Graphics: WebRender
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla58
Tracking Flags:
Tracking Status
firefox57 --- unaffected
firefox58 --- unaffected

People

(Reporter: vliu, Assigned: ethlin)

References

Details

(Whiteboard: [wr-mvp])

Attachments

(1 file, 1 obsolete file)

Bug 1406272 - Enable talos-chrome and talos-g1 for linux64-qr.
59 bytes, text/x-review-board-request
kats
: review+
Details 
This is the following bug when Bug 1377894 was landed. With the patch of Bug 1377894, it hits TalosError("timeout") on linux64 qr opt build. See [1] for details.

[1]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3610ecf157ef531ec9487416fd345df75e44ae58&selectedJob=134409601&filter-searchStr=Linux%20x64%20QuantumRender%20opt%20Talos%20Performance%20e10s%20Talos%20chrome%20e10s%20T-e10s(c)

The below is snippet of error message.

TEST-INFO | started process 4017 (/builds/slave/test/build/application/firefox/firefox -profile /tmp/tmpEG8Phq/profile http://localhost:47212/startup_test/tresize/addon/content/tresize-test.html)
07:33:39     INFO -  PID 4017 | WebRender - OpenGL version new 3.2.0 NVIDIA 361.42
07:33:40     INFO -  PID 4017 |
07:33:40     INFO -  PID 4017 | (/builds/slave/test/build/application/firefox/firefox:4072): Pango-WARNING **: error opening config file '/home/cltbld/.pangorc': Permission denied
07:33:40     INFO -  PID 4017 |
07:36:09     INFO -  Timeout waiting for test completion; killing browser...
07:36:09     INFO -  Terminating psutil.Process(pid=4017, name='firefox')
07:36:09     INFO -  PID 4017 | ExceptionHandler::GenerateDump cloned child 4162
07:36:09     INFO -  PID 4017 | ExceptionHandler::SendContinueSignalToChild sent continue signal to child
07:36:09     INFO -  PID 4017 | ExceptionHandler::WaitForContinueSignal waiting for continue signal...
07:36:09     INFO -  TEST-UNEXPECTED-ERROR | tresize | timeout
07:36:09    ERROR -  Traceback (most recent call last):
07:36:09     INFO -    File "/builds/slave/test/build/tests/talos/talos/run_tests.py", line 281, in run_tests
07:36:09     INFO -      talos_results.add(mytest.runTest(browser_config, test))
07:36:09     INFO -    File "/builds/slave/test/build/tests/talos/talos/ttest.py", line 61, in runTest
07:36:09     INFO -      return self._runTest(browser_config, test_config, setup)
07:36:09     INFO -    File "/builds/slave/test/build/tests/talos/talos/ttest.py", line 209, in _runTest
07:36:09     INFO -      if counter_management else None),
07:36:09     INFO -    File "/builds/slave/test/build/tests/talos/talos/talos_process.py", line 130, in run_browser
07:36:09     INFO -      raise TalosError("timeout")
07:36:09     INFO -  TalosError: timeout
With the patch, the error message of talos-svgr becomes "Could not find report in browser output: [('tsformat', ('__start_report', '__end_report')), ('tpformat', ('__start_tp_report', '__end_tp_report'))]".
Assignee: nobody → ethlin
Whiteboard: [wr-mvp] [triage]
Comment on attachment 8915894 [details]
Bug 1406272 - Make chrome always call NotifyInvalidation in each transaction.

https://reviewboard.mozilla.org/r/187148/#review192344

I think this might result in infinite painting loops in the parent process. It's not clear to me why this is needed. I did a try push with the talos tests enabled but *without* this patch, and the chrome and g1 tests are passing now. I think they were fixed by our earlier invalidation fixes. So r- for this patch, because I think it won't help anything but might make things worse.
Attachment #8915894 - Flags: review?(bugmail) → review-
Comment on attachment 8915895 [details]
Bug 1406272 - Enable talos-chrome and talos-g1 for linux64-qr.

https://reviewboard.mozilla.org/r/187150/#review192346

Based on the try push at https://treeherder.mozilla.org/#/jobs?repo=try&revision=540e87501d581a4f8da01f823d208aefa2add341 I think we can just land this patch without the other one, the talos tests are green now.

::: taskcluster/ci/test/test-sets.yml:102
(Diff revision 1)
> -    # - talos-chrome # fails with layers-free
> +    - talos-chrome # fails with layers-free
>      - talos-dromaeojs
> -    # - talos-g1 # fails with layers-free
> +    - talos-g1 # fails with layers-free

Remove the "# fails with layers-free comment" as well on these
Attachment #8915895 - Flags: review?(bugmail) → review+
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [wr-mvp] [triage] → [wr-mvp]
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #6)
> Comment on attachment 8915895 [details]
> Bug 1406272 - Enable talos-chrome and talos-g1 for linux64-qr.
> 
> https://reviewboard.mozilla.org/r/187150/#review192346
> 
> Based on the try push at
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=540e87501d581a4f8da01f823d208aefa2add341 I think we
> can just land this patch without the other one, the talos tests are green
> now.
> 
> ::: taskcluster/ci/test/test-sets.yml:102
> (Diff revision 1)
> > -    # - talos-chrome # fails with layers-free
> > +    - talos-chrome # fails with layers-free
> >      - talos-dromaeojs
> > -    # - talos-g1 # fails with layers-free
> > +    - talos-g1 # fails with layers-free
> 
> Remove the "# fails with layers-free comment" as well on these

Oh, that's right. So it's not about the fix.
Attachment #8915894 - Attachment is obsolete: true
Pushed by ethlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e46e58f218bd
Enable talos-chrome and talos-g1 for linux64-qr. r=kats
https://hg.mozilla.org/mozilla-central/rev/e46e58f218bd
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: