Closed Bug 1406284 Opened 3 years ago Closed 3 years ago

stylo: Remove unused parent context argument in ServoStyleSet

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox57 --- wontfix
firefox58 --- fixed

People

(Reporter: hiro, Assigned: hiro)

Details

Attachments

(1 file)

ServoStyleSet::GetBaseContextForElement and ResolveStyleLazilyInternal take parent ServoStyleContext, but it never uses there.

As for GetBaseContextForelement, it's not used in the first place;
<https://hg.mozilla.org/mozilla-central/rev/7c1ac965de93#l3.17>

As for ResolveStyleLazilyInternal, it's not used since this commit <https://hg.mozilla.org/mozilla-central/rev/7c637424657f#l4.217>

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6154bbf1dc78e3f793ed81854e861479280608a3
Comment on attachment 8915845 [details]
Bug 1406284 - Remove unused parent context argument.

https://reviewboard.mozilla.org/r/187082/#review192106
Attachment #8915845 - Flags: review?(cam) → review+
Priority: -- → P4
Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ec7c9e40fdc5
Remove unused parent context argument. r=heycam
https://hg.mozilla.org/mozilla-central/rev/ec7c9e40fdc5
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Assignee: nobody → hikezoe
You need to log in before you can comment on or make changes to this bug.