Closed Bug 1406305 Opened 3 years ago Closed 3 years ago

Remove unused aguments in StackingContextHelper's contructor

Categories

(Core :: Graphics: WebRender, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox57 --- unaffected
firefox58 --- unaffected

People

(Reporter: kechen, Assigned: kechen)

References

(Blocks 1 open bug)

Details

(Whiteboard: [wr-reserve])

Attachments

(1 file)

According to Bug 1401898 comment 5, we can get rid of unused arguments in the constructor and make it more clear.
Assignee: nobody → kechen
Attachment #8915857 - Flags: review?(bugmail)
Whiteboard: [wr-mvp] → [wr-mvp] [triage]
Comment on attachment 8915857 [details]
Bug 1406305 - Remove unused arguments in StackingContextHelper's constructor;

https://reviewboard.mozilla.org/r/187098/#review192358
Attachment #8915857 - Flags: review?(bugmail) → review+
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [wr-mvp] [triage] → [wr-reserve]
Depends on: 1401898
Keywords: checkin-needed
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 3ea7c1a7bc4b -d 5f336a4ae6ce: rebasing 424752:3ea7c1a7bc4b "Bug 1406305 - Remove unused arguments in StackingContextHelper's constructor; r=kats" (tip)
merging gfx/layers/wr/WebRenderCommandBuilder.cpp
merging layout/painting/nsDisplayList.cpp
warning: conflicts while merging gfx/layers/wr/WebRenderCommandBuilder.cpp! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/76a08a6dc6e6
Remove unused arguments in StackingContextHelper's constructor; r=kats
https://hg.mozilla.org/mozilla-central/rev/76a08a6dc6e6
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.