Closed Bug 1406308 Opened 2 years ago Closed 2 years ago
_RELEASE _ASSERT on ns Html5Stream Parser::m Stream State
59 bytes, text/x-review-board-request
Bug 1396395 would have been understood and fixed much sooner if the assertions on mStreamState were MOZ_RELEASE_ASSERTs.
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
Comment on attachment 8915860 [details] Bug 1406308 - MOZ_RELEASE_ASSERT on nsHtml5StreamParser::mStreamState. https://reviewboard.mozilla.org/r/187108/#review192256 Do you want RELEASE or DIAGNOSTIC asserts? I think I'd prefer the latter, but up to you.
Attachment #8915860 - Flags: review?(bugs) → review+
Thanks. I meant RELEASE. If the condition doesn't hold, a lot of reasoning the code is based on is wrong. While the crashes I've seen so far happened to be non-dangerous, it's still pretty scary to have this code running without the preconditions holding. (Hopefully no longer can happen thanks to the fix for bug 1396395.)
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/a7db27937e4f MOZ_RELEASE_ASSERT on nsHtml5StreamParser::mStreamState. r=smaug
You need to log in before you can comment on or make changes to this bug.