Closed Bug 1406308 Opened 2 years ago Closed 2 years ago

MOZ_RELEASE_ASSERT on nsHtml5StreamParser::mStreamState

Categories

(Core :: DOM: HTML Parser, enhancement, trivial)

enhancement
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: hsivonen, Assigned: hsivonen)

Details

Attachments

(1 file)

Bug 1396395 would have been understood and fixed much sooner if the assertions on mStreamState were MOZ_RELEASE_ASSERTs.
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
Comment on attachment 8915860 [details]
Bug 1406308 - MOZ_RELEASE_ASSERT on nsHtml5StreamParser::mStreamState.

https://reviewboard.mozilla.org/r/187108/#review192256

Do you want RELEASE or DIAGNOSTIC asserts? I think I'd prefer the latter, but up to you.
Attachment #8915860 - Flags: review?(bugs) → review+
Thanks. I meant RELEASE. If the condition doesn't hold, a lot of reasoning the code is based on is wrong. While the crashes I've seen so far happened to be non-dangerous, it's still pretty scary to have this code running without the preconditions holding. (Hopefully no longer can happen thanks to the fix for bug 1396395.)
Pushed by hsivonen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a7db27937e4f
MOZ_RELEASE_ASSERT on nsHtml5StreamParser::mStreamState. r=smaug
https://hg.mozilla.org/mozilla-central/rev/a7db27937e4f
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.