1406310 - Also ship clang-format in the clang-tidy build job

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, enhancement)

Description

[Sylvestre Ledru [:Sylvestre]]

Instead of creating a new job, I propose that we use the clang-tidy artifact.
we should probably rename it as a next step like "clang-tooling" or "clang-toolchain".

Comment 1

[Andi [:andi]]

I propose using already implemented helper for getting the resources: https://dxr.mozilla.org/mozilla-central/source/python/mozbuild/mozbuild/mach_commands.py#2385
And besides this maybe it's a good idea to also keep the same directory for the resources, and like you said renaming it to clang-tooling.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1406310 - Also ship clang-format in the clang-tidy build job

Review commit: https://reviewboard.mozilla.org/r/187112/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187112/

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8915863 [details]
Bug 1406310 - Also ship clang-format in the clang-tidy build job

https://reviewboard.mozilla.org/r/187112/#review193054

Don't land this until bug 1405570 is fixed.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1daa8a6f30db
Also ship clang-format in the clang-tidy build job r=glandium

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/1daa8a6f30db